Route53 Signer and Provider - #1025
Open
enriquemanuel wants to merge 1 commit into
Open
Conversation
enriquemanuel
commented
Aug 9, 2025
enriquemanuel
commented
- Move the Signer to use AWS SDK
- Allow to specify AWS_PROFILE or Keys
- If using aws_profile it can be with SSO and Session Tokens
- Show the role and or profile being used in logs
simonmarty
reviewed
Aug 25, 2025
| "net/url" | ||
| "time" | ||
|
|
||
| "github.com/aws/aws-sdk-go/aws/credentials" |
Contributor
There was a problem hiding this comment.
Go SDK v1 is EOL https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/
You're gonna want to use github.com/aws/aws-sdk-go-v2/
Owner
|
That was previously dependency free, I expect for it to stay dependency free, and feel free to add features to the existing provider code, but without importing huge sdk dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.