Allow Diagonal

[akubeejays]

I tried to allow diagonal but it does not find a solution when "dontcrosscorners" is set to false. is any one else facing the same issue and can anyone help me with a solution ?

var matrix = [
[1, 1, 1, 1, 1, 1, 1],
[1, 1, 1, 1, 1, 1, 1],
[1, 1, 0, 1, 0, 1, 1],
[1, 1, 1, 0, 1, 1, 1],
[1, 1, 1, 1, 1, 1, 1],

];
var grid = new PF.Grid(7, 5, matrix);

var finder = new PF.AStarFinder({
allowDiagonal: true,
dontCrossCorners: false

});

var path = finder.findPath(2, 2, 4, 2, grid);

[qiao]

https://github.com/qiao/PathFinding.js/blob/master/src/core/Grid.js#L170

                   +-----+-----+-----+
                   |     |  A  |  B  |
                   +-----|-----|-----+
                   |     |  C  |  D  |
                   +-----|-----|-----+
                   |     |     |     |
                   +-----+-----+-----+

For the current implementation,

if dontCrossCorners is set to true, then, in order to go from C to B, both A and B must be walkable,
and if dontCrossCorners is set to false, then at least one of A and B must be walkable.
There's no way if neither of A nor B is walkable. I think I should add another strategy into the algorithm to make it possible.

[akubeejays]

Is there any code changes you can recommend for me to change to allow this until it is made into the final release?

Regards,
Ben
(Sent from my iPhone)

On 12 Jul 2013, at 13:42, Xueqiao Xu notifications@github.com wrote:

https://github.com/qiao/PathFinding.js/blob/master/src/core/Grid.js#L170

               +-----+-----+-----+
               |     |  A  |  B  |
               +-----|-----|-----+
               |     |  C  |  D  |
               +-----|-----|-----+
               |     |     |     |
               +-----+-----+-----+

For the current implementation,

if dontCrossCorners is set to true, then, in order to go from C to B, both A and B must be walkable,

and if dontCrossCorners is set to false, then at least one of A and B must be walkable.

There's no way if neither of A nor B is walkable. I think I should add another strategy into the algorithm to make it possible.

—
Reply to this email directly or view it on GitHub.

[qiao]

Yes, you can modify the code starting from this line: https://github.com/qiao/PathFinding.js/blob/master/src/core/Grid.js#L170

delete the if-else block and assign d0, d1, d2 and d3 to be all true and that's done.

[akubeejays]

Perfect J

From: Xueqiao Xu [mailto:notifications@github.com]
Sent: Friday, July 12, 2013 2:17 PM
To: qiao/PathFinding.js
Cc: akubeejays
Subject: Re: [PathFinding.js] Allow Diagonal (#37)

Yes, you can modify the code starting from this line: https://github.com/qiao/PathFinding.js/blob/master/src/core/Grid.js#L170

delete the if-else block and assign d0, d1, d2 and d3 to be all true and that's done.

—
Reply to this email directly or view it on GitHub #37 (comment) . https://github.com/notifications/beacon/3snu1tkl9JD8oSdg7_1940VU1aGahrIc51__Y6coHhZedzHlgb7u0Y_5BclmtXNY.gif

[horaguchi]

Yes, you can modify the code starting from this line: https://github.com/qiao/PathFinding.js/blob/master/src/core/Grid.js#L170

delete the if-else block and assign d0, d1, d2 and d3 to be all true and that's done.

I use PathFinding.js with this modification too.
I am very happy if I can upgrade version without every modification.
Would it be possible to optionize this?

[imor]

Will be fixed once #63 is done.

[imor]

Hi @horaguchi #63 is mostly done apart from polishing the docs. But the code is not yet released in a new version (I don't have the access to release to npmjs yet :( ) so you'll have to use the code from the repo. Read the user guide for more information.

[horaguchi]

@imor Sorry for the late reply: I tried it and it works correctly :). Thank you very much.