Skip to content

add linked sequence formats, type, tests - #388

Merged
ebolyen merged 7 commits into
qiime2:devfrom
colinvwood:linked-sequences
May 18, 2026
Merged

ebolyen merged 7 commits into
qiime2:devfrom
colinvwood:linked-sequences

Conversation

@colinvwood

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread q2_types/feature_data/_formats.py Outdated
Comment thread q2_types/feature_data/_formats.py Outdated
Comment thread q2_types/feature_data/_deferred_setup/_transformers.py
@colinvwood colinvwood mentioned this pull request Mar 30, 2026
1 of 2 tasks
@colinvwood

Copy link
Copy Markdown
Contributor Author

@ebolyen I added pd.Series transformers as it looks like those are widely used downstream, and updated the parent of LinkedDNAFASTAFormat so we can += ' ' to the alphabet. This is everything I have planned for the q2-types side of things, lmk if you have ideas for anything else we need.

@colinvwood colinvwood moved this from In Development to In Review in 2026.4 🌱 Mar 31, 2026
@colinvwood colinvwood self-assigned this Mar 31, 2026
@Oddant1 Oddant1 assigned Oddant1 and unassigned colinvwood Apr 3, 2026
@Oddant1
Oddant1 self-requested a review April 3, 2026 17:33

@Oddant1 Oddant1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm. I think @ebolyen hit everything. I still need to properly get through the other PR especially the R stuff...

Comment thread q2_types/feature_data/_deferred_setup/_transformers.py
@Oddant1 Oddant1 moved this from In Review to In Development in 2026.4 🌱 Apr 6, 2026
@colinvwood colinvwood moved this from In Development to In Review in 2026.4 🌱 Apr 10, 2026
@lizgehret lizgehret removed this from 2026.4 🌱 Apr 23, 2026
@github-project-automation github-project-automation Bot moved this to In Development in 2026.7 🐐 Apr 23, 2026
@lizgehret lizgehret moved this from In Development to In Review in 2026.7 🐐 Apr 23, 2026

@ebolyen ebolyen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colinvwood!

@github-project-automation github-project-automation Bot moved this from In Review to Ready for Merge in 2026.7 🐐 May 18, 2026
@ebolyen
ebolyen merged commit 732057a into qiime2:dev May 18, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Merge to Changelog Needed in 2026.7 🐐 May 18, 2026
@Oddant1 Oddant1 removed their assignment Jun 9, 2026
@colinvwood colinvwood removed their assignment Jun 12, 2026
@colinvwood colinvwood removed this from 2026.7 🐐 Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants