Repository navigation
MAINT: move Importance formats and type to q2-types - #390
Merged
Merged
Conversation
This was referenced May 12, 2026
ebolyen
approved these changes
Jun 12, 2026
ebolyen
left a comment
Member
There was a problem hiding this comment.
Looks great, thanks @VinzentRisch!
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the shared FeatureData[Importance] type and importance TSV formats into q2-types so downstream plugins can use them without depending on q2-sample-classifier. The _MultiColumnNumericFormat was removed and the logic was moved directly to the ImportanceFormat.
Added
This PR was created in parts with Codex 5.5