Skip to content

MAINT: move Importance formats and type to q2-types - #390

Merged
ebolyen merged 4 commits into
qiime2:devfrom
VinzentRisch:389_move_formats_importance
Jun 12, 2026
Merged

ebolyen merged 4 commits into
qiime2:devfrom
VinzentRisch:389_move_formats_importance

Conversation

@VinzentRisch

@VinzentRisch VinzentRisch commented May 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Moves the shared FeatureData[Importance] type and importance TSV formats into q2-types so downstream plugins can use them without depending on q2-sample-classifier. The _MultiColumnNumericFormat was removed and the logic was moved directly to the ImportanceFormat.

Added

  • Type: Importance
  • Format classes: ImportanceFormat, ImportanceDirectoryFormat
  • Registrations: Importance semantic type, ImportanceFormat, ImportanceDirectoryFormat, FeatureData[Importance] -> ImportanceDirectoryFormat
  • Transformers: pd.DataFrame -> ImportanceFormat, ImportanceFormat -> pd.DataFrame, ImportanceFormat -> qiime2.Metadata
  • Tests and fixtures for importance format validation, type/format registration, and transformers

This PR was created in parts with Codex 5.5

@VinzentRisch VinzentRisch changed the title MAINT: move importance formats to q2-types MAINT: move Importance formats and type to q2-types May 19, 2026

@ebolyen ebolyen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @VinzentRisch!

@github-project-automation github-project-automation Bot moved this from Backlog to Ready for Merge in 2026.7 🐐 Jun 12, 2026
@ebolyen
ebolyen merged commit 2839482 into qiime2:dev Jun 12, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Merge to Changelog Needed in 2026.7 🐐 Jun 12, 2026
@ebolyen ebolyen assigned VinzentRisch and unassigned ebolyen Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Changelog Needed

Development

Successfully merging this pull request may close these issues.

MAINT: move FeatureData[Importance] type and formats from q2-sample-classifier

3 participants