Skip to content

FASTAFormat validator refactor - #395

Merged
colinvwood merged 3 commits into
qiime2:devfrom
Macabe222:aligned-seq-validate
Jun 17, 2026
Merged

colinvwood merged 3 commits into
qiime2:devfrom
Macabe222:aligned-seq-validate

Conversation

@Macabe222

Copy link
Copy Markdown
Contributor

Description

FASTAFormat validator fails if the there is only one sequence in the file, as prev_seq_len is set to the length of the sequence but seq_len is never set. Fixes this by counting the number of sequences in the file and skipping the final
_validate_line_lengths if there is only one sequence (all sequences will be the same length since there is only one). Also addresses #393.

AI Disclosure

  • NO AI USED.
  • AI USED.

AI Usage Details

Comment thread q2_types/feature_data/_formats.py Outdated
Comment thread q2_types/feature_data/_formats.py Outdated
@Macabe222
Macabe222 requested a review from colinvwood June 17, 2026 19:26
@colinvwood
colinvwood merged commit 451ab0f into qiime2:dev Jun 17, 2026
5 checks passed
@colinvwood colinvwood removed their assignment Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants