Repository navigation
IMP: collate contig-maps - #405
Merged
Merged
Conversation
fethalen
requested changes
Sep 24, 2026
fethalen
left a comment
fethalen
left a comment
Contributor
There was a problem hiding this comment.
Hi, @ZuzanaSebb, good job on this. Could you quickly have a look at the comments that I've made?
| "contig_maps": "A collection of MAG-to-contig maps to be collated." | ||
| }, | ||
| name="Collate MAG-to-contig maps", | ||
| description="Takes a collection of FeatureMap[MAGtoContigs]'s " |
Contributor
There was a problem hiding this comment.
FeatureMap[MAGtoContigs]'s -> FeatureMap[MAGtoContigs]s
| ) | ||
| from q2_types.feature_data import FeatureData, Sequence | ||
| from q2_types.feature_map import FeatureMap, MAGtoContigs | ||
| from q2_types.feature_map._methods import collate_contig_maps |
Contributor
There was a problem hiding this comment.
Since collate_contigs_maps has already been exported in __init__.py, I think that you can replace these 2 lines with one:
from q2_types.feature_map import FeatureMap, MAGtoContigs, collate_contig_maps| # ---------------------------------------------------------------------------- | ||
| from qiime2.plugin.testing import TestPluginBase | ||
|
|
||
| from q2_types.feature_map._methods import collate_contig_maps |
Contributor
There was a problem hiding this comment.
Putting ._methods is probably unnecessary since __init__.py already exports collate_contig_maps
Contributor
|
Hi, @ZuzanaSebb. The fixes looks great. I've tested with the data you gave me and everything is working as expected. Great job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds function to collate contig-maps. Related to #14
AI Disclosure
AI Usage Details
Claude (Sonnet 5) was used to generate descriptors in plugin_setup.py.