Repository navigation
refactor PushFileToCentralHandler to transfer ONE file, but chunked - #3519
Merged
Merged
Conversation
…bs, but the later must also made known by the DB
This was referenced Apr 27, 2026
Merged
…ble to the worker that composes the original file
Chunked filetransfer sharedtmp
antgonza
reviewed
May 8, 2026
antgonza
left a comment
Member
There was a problem hiding this comment.
Well, this is awkard, I forgot to submit this comment 2 weeks ago, sorry.
| self.assertIn("already present in Qiita's BASE_DATA_DIR!", | ||
| obs.reason) | ||
|
|
||
| # I ditched sending multiple files on 2026-03.24 in favor of a clean |
Member
There was a problem hiding this comment.
Can you delete this block? I'm not sure why we would like it here.
Contributor
Author
There was a problem hiding this comment.
sure. This was more a note to myself and shouldn't end up here. Sorry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to realize that pushing larger (>2 GB) files from client to Qiita main exceeds some limited. Therefore, we need to transfer files in a chunked fashion, similar to file upload to Qiita.
This PR refactors PushFileToCentralHandler::push such that it transfers a single chunk of a single file. The consumer needs to define the chunk number and total expected chunks, too.
Error was