Repository navigation
fix(acp): filter configured models and surface failed turns - #14
Merged
Merged
Conversation
Scope model discovery to locally configured providers, retaining the active selection. Send a labeled failure notice before structured prompt errors and include bounded DeepSeek network diagnostics in source and npm runtimes. Add Markdown output guidance, document the limits, and cover configuration, errors, cancellation, and packaged ACP behavior. Validation: documentation checker, lint, 1102 unit tests, source ACP probe, npm build and package verification passed; new error patch helpers have 100% coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ACP model choices now follow local provider configuration. Failed model turns send a labeled diagnostic text update before returning a structured JSON-RPC error, so clients can show and retain the failure instead of ending with only an idle indicator.
Why
Addresses failure feedback and bounded diagnostics in KEV-94 and KEV-95, plus the agent-side guidance in KEV-99. Console rendering changes and history compatibility coverage are in pax-beehive/pax-console#180.
Checks run
npm run lint.npm run check: lint, both TypeScript checks, coverage, integration, package verification, and 63 evaluation tests passed. Ran outside the restricted sandbox because local test listeners require it.npm run test:unit: 1,102 tests passed.Notes
Configuration is not a reachability or credential-validity check; reconnect after credential changes. This does not establish the root cause of the reported repeated transport failures. The failure notice covers terminal model-turn errors; it is not a replacement for every admission or transport error path. Markdown guidance does not guarantee valid output from every model.
No npm release, version bump, or deployment is included. Linux container end-to-end checks remain for CI.