Skip to content

Remove qsimh mention from docs - #1103

Open
kris524 wants to merge 2 commits into
quantumlib:mainfrom
kris524:issue-772
Open

Remove qsimh mention from docs#1103
kris524 wants to merge 2 commits into
quantumlib:mainfrom
kris524:issue-772

Conversation

@kris524

@kris524 kris524 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Closes #772

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions Bot added the size: XL lines changed >1000 label Aug 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request completely removes the hybrid Schrödinger-Feynman simulator (qsimh / QSimhSimulator) from the repository, including its binaries, build targets, Python/Pybind11 interfaces, and documentation. The review feedback highlights several necessary cleanups to prevent compilation errors and orphaned files, such as removing the pybind11 binding registration for qsimh_simulate, deleting unused source files (lib/hybrid.h, lib/run_qsimh.h, qsimcirq/qsimh_simulator.py and its tests), and removing outdated keywords from pyproject.toml.

Comment thread pybind_interface/pybind_main.cpp
Comment thread qsimcirq/__init__.py
Comment thread lib/BUILD
Comment thread pyproject.toml Outdated
@github-actions github-actions Bot added size: L 250< lines changed <1000 and removed size: XL lines changed >1000 labels Aug 28, 2026
@kris524

kris524 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Question: Do we want to remove the whole qsimh implementation as part of this MR? Or only update the docs not to mention it?

@kris524 kris524 changed the title Remove qsimh Remove qsimh mention from docs Aug 28, 2026
@mhucka

mhucka commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Question: Do we want to remove the whole qsimh implementation as part of this MR? Or only update the docs not to mention it?

@kris524 Thank you for tackling this task.

  • Regarding removing the implementation: let's leave it in for now. Sergei Isakov has made a separate PR with substantial code changes, and I'm worried that removing the qsimh code will lead to merge conflicts for that other PR. Once the other one is merged, a subsequent PR can remove the qsimh code.

  • Regarding this PR: could you also remove mention of qsimh from the top-level README.md file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: L 250< lines changed <1000

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove qsimh

2 participants