Repository navigation
Fix Windows clippy failure in quarto-mcp-launcher + document the Windows cross-check recipe (bd-j0pgiips, bd-tkubuse4) - #913
Merged
Conversation
… (bd-j0pgiips) q2_path_injection_skips_non_utf8_exe_paths built its non-UTF-8 OsString via the unix-only OsStringExt::from_vec, so `cargo clippy -p quarto-mcp-launcher --all-targets -- -D warnings` (a cargo xtask verify step) failed on Windows with E0433/E0599, and the crate's whole test target was un-runnable there — masking 4 more Windows failures in cache_tests (filed as bd-5tdzaf3t). Per .claude/rules/cross-platform.md, keep the test portable: a cfg pair of non_utf8_os_string() helpers — from_vec(0xff, 0xfe) on unix, from_wide(lone surrogate) on Windows — so the same q2_path_for_child rejection path is exercised on all three platforms. Verified on Windows: clippy -D warnings green; 27/27 lib tests pass.
…kubuse4) Windows is not in CI, and each feature PR kept breaking it because neither .claude/rules/cross-platform.md nor claude-notes/instructions/windows-dev.md told contributors HOW to verify a Windows build without a Windows machine. - cross-platform.md: new 'Verify before landing' section with the recipe: cargo clippy -p <crate> --all-targets --target x86_64-pc-windows-msvc -- -D warnings (check/clippy don't link, so no MSVC toolchain needed on unix), plus the C-build-script caveat and the compilation-only scope limit. - windows-dev.md: CI section now points at the same recipe as the pre-landing gate. - AGENTS.md: replaced the stale 'crates must be manually excluded from tests' testing bullet (resolved 2026-03-23) with the cross-check rule. Recipe validated on Windows: against the pre-fix bd-j0pgiips code it reproduces the exact E0433/E0599 clippy failure; against the fixed code it is clean. NOTE: validated natively on Windows, not cross from unix; the no-link claim is standard cargo behavior but the first unix run may surface per-crate build-script quirks.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two commits from the Windows test-health work:
bd-j0pgiips —
cargo xtask verify's clippy step failed on Windows:q2_path_injection_skips_non_utf8_exe_paths(introduced in hub-mcp Phase 4: Quarto-specific intelligence (bd-738mbhpj) #797) built its non-UTF-8OsStringvia the unix-onlyOsStringExt::from_vec, so the crate's whole test target didn't compile on Windows. Per.claude/rules/cross-platform.md, the test stays portable via acfg-pair helper:from_vec([0xff, 0xfe])on unix,from_wide(&[0xD800])(lone surrogate) on Windows — sameto_str()→Nonerejection path on all three platforms.bd-tkubuse4 — docs-only: Windows is not in CI, and neither the cross-platform rule nor windows-dev.md said HOW to verify a Windows build without a Windows machine. Adds the cross-check recipe (
cargo clippy -p <crate> --all-targets --target x86_64-pc-windows-msvc -- -D warnings— check/clippy don't link, so no MSVC toolchain needed on unix) to.claude/rules/cross-platform.mdandclaude-notes/instructions/windows-dev.md, and replaces AGENTS.md's stale 'crates must be manually excluded' bullet.Test plan
cargo clippy -p quarto-mcp-launcher --all-targets -- -D warningsgreen;cargo nextest run -p quarto-mcp-launcher --lib27/27 passq2 render --strict claude-notes/instructions/windows-dev.mdcleancargo xtask verifyNOT run: still red on Windows from bd-lhi82470 (in progress, separate fix)Follow-ups (out of scope)
quarto-mcp-launchercache_tests(re-extraction/GC paths; Windows file-locking family)