Repository navigation
Conversation
Windows compile breakage keeps reaching main undetected because every CI leg runs on Linux/macOS: Unix-only APIs (std::os::unix, OsStringExt::from_vec) and asymmetric #[cfg] gates pass clippy there and only fail on a Windows machine. The recent instances (quarto-mcp- launcher non-UTF-8 test, xtask capture-* dead code) were all compile-level failures that clippy --all-targets on Windows catches without running a single test. Add a windows-clippy job running the same gate as the existing "Clippy (deny warnings)" step: cargo clippy --workspace --all-targets --profile ci -- -D warnings. Compile-only, so it skips the matrix job's pandoc/typst/tree-sitter/ node setup (verified on a fresh Windows checkout: green, ~8 min cold). A full Windows test leg remains separate work. No cargo xtask verify counterpart: verify already runs this exact clippy command on the host platform, so this is the same gate on another OS rather than a new gating step.
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows compile breakage keeps reaching main undetected: every CI leg runs on Linux/macOS, so Unix-only APIs (
std::os::unix,OsStringExt::from_vec) and asymmetric#[cfg]gates pass clippy there and only fail on a Windows machine. The three recent instances — the quarto-mcp-launcher non-UTF-8 test (#913), the xtask capture-* dead code (#834), and the cache-test coverage masked by an upstream compile failure (#914) — were all compile-level failures thatclippy --all-targetson Windows catches without running a single test.Stacked on #913: the leg is red without that fix, so this PR targets its branch and GitHub will auto-retarget to main when #913 merges. Only the last commit is new.
Add a
windows-clippyjob to test-suite.yml running the same gate as the existing "Clippy (deny warnings)" step:Compile-only (
--all-targetsstill compiles test and dev-tool code, which is where these failures live), so the job skips the matrix leg's pandoc/typst/tree-sitter/node setup. Verified on a fresh Windows checkout of #913 merged into main: green, ~8 min cold.Scope notes:
cargo xtask verifycounterpart: verify already runs this exact clippy command on the host platform, so this is the same gate on another OS, not a new gating step.