Merge test/smoke-tests-built-version into gha-log-grouping

Pulls the Playwright-setup bucket gate (combined with the quarto-install guard) into the log-grouping PR so its CI runs skip Playwright setup on the built smoke leg that never uses it.

Author: cderv

.github/workflows/test-smokes.yml

@@ -120,8 +120,18 @@ jobs:
         with:
           node-version: 22
 
+      # Playwright setup is only needed when this job can actually run the
+      # playwright suite: a bucket containing playwright-tests.test.ts, or a
+      # full run (empty buckets, which includes integration/). Windows never
+      # needs it: the suite is ignored on Windows CI (playwright-tests.test.ts,
+      # `ignore: gha.isGitHubActions() && isWindows`).
+      # Binary/release full runs (empty buckets, quarto-install != dev) default to the smoke/ corpus and never run playwright.
       - name: Cache multiplex server node_modules
-        if: ${{ runner.os != 'Windows' || github.event_name == 'schedule' || (inputs.quarto-install != 'dev' && inputs.quarto-install != '') }}
+        if: >-
+          runner.os != 'Windows'
+          && (contains(inputs.buckets, 'playwright-tests.test.ts')
+              || (format('{0}', inputs.buckets) == ''
+                  && (inputs.quarto-install == 'dev' || inputs.quarto-install == '')))
         uses: actions/cache@v5
         with:
           path: tests/integration/playwright/multiplex-server/node_modules
@@ -130,21 +140,33 @@ jobs:
             ${{ runner.os }}-multiplex-server-
 
       - name: Install node dependencies
-        if: ${{ runner.os != 'Windows' || github.event_name == 'schedule' || (inputs.quarto-install != 'dev' && inputs.quarto-install != '') }}
+        if: >-
+          runner.os != 'Windows'
+          && (contains(inputs.buckets, 'playwright-tests.test.ts')
+              || (format('{0}', inputs.buckets) == ''
+                  && (inputs.quarto-install == 'dev' || inputs.quarto-install == '')))
         run: npm install --loglevel=error --no-audit
         working-directory: ./tests/integration/playwright
         shell: bash
 
       - name: Get Playwright version
-        if: ${{ runner.os != 'Windows' || github.event_name == 'schedule' || (inputs.quarto-install != 'dev' && inputs.quarto-install != '') }}
+        if: >-
+          runner.os != 'Windows'
+          && (contains(inputs.buckets, 'playwright-tests.test.ts')
+              || (format('{0}', inputs.buckets) == ''
+                  && (inputs.quarto-install == 'dev' || inputs.quarto-install == '')))
         run: |
           VERSION=$(node -p "require('@playwright/test/package.json').version")
           echo "PLAYWRIGHT_VERSION=$VERSION" >> "$GITHUB_ENV"
         working-directory: ./tests/integration/playwright
         shell: bash
 
       - name: Cache Playwright browsers
-        if: ${{ runner.os != 'Windows' || github.event_name == 'schedule' || (inputs.quarto-install != 'dev' && inputs.quarto-install != '') }}
+        if: >-
+          runner.os != 'Windows'
+          && (contains(inputs.buckets, 'playwright-tests.test.ts')
+              || (format('{0}', inputs.buckets) == ''
+                  && (inputs.quarto-install == 'dev' || inputs.quarto-install == '')))
         uses: actions/cache@v5
         with:
           path: ${{ env.PLAYWRIGHT_BROWSERS_PATH }}
@@ -153,13 +175,21 @@ jobs:
             ${{ runner.os }}-playwright-
 
       - name: Install Playwright system dependencies
-        if: ${{ runner.os != 'Windows' || github.event_name == 'schedule' || (inputs.quarto-install != 'dev' && inputs.quarto-install != '') }}
+        if: >-
+          runner.os != 'Windows'
+          && (contains(inputs.buckets, 'playwright-tests.test.ts')
+              || (format('{0}', inputs.buckets) == ''
+                  && (inputs.quarto-install == 'dev' || inputs.quarto-install == '')))
         timeout-minutes: 15
         run: npx playwright install-deps
         working-directory: ./tests/integration/playwright
 
       - name: Install Playwright Browsers
-        if: ${{ runner.os != 'Windows' || github.event_name == 'schedule' || (inputs.quarto-install != 'dev' && inputs.quarto-install != '') }}
+        if: >-
+          runner.os != 'Windows'
+          && (contains(inputs.buckets, 'playwright-tests.test.ts')
+              || (format('{0}', inputs.buckets) == ''
+                  && (inputs.quarto-install == 'dev' || inputs.quarto-install == '')))
         timeout-minutes: 15
         run: npx playwright install
         working-directory: ./tests/integration/playwright

dev-docs/cross-project-dependencies.md

@@ -65,6 +65,11 @@ format of editor-support commands is a cross-project change.
 3. For filters: confirm inline-list membership in `prepare-dist.ts`.
 4. Coordinate a companion PR in the consumer if the contract changes.
 
+Bumping the bundled Pandoc version counts as touching a shared surface:
+Pandoc Markdown-writer changes alter the visual-editor roundtrip output in
+`quarto-dev/quarto` and can break its snapshot tests. See the last item of
+[`update-pandoc-checklist.md`](update-pandoc-checklist.md).
+
 ## History
 
 - Removing `crossref-standalone.lua` and `quarto-pre/quarto-pre.lua`: verified

dev-docs/update-pandoc-checklist.md

@@ -29,3 +29,4 @@ Partials:
 
 - [ ] Update schemas by inspecting [their changelog](https://github.com/jgm/pandoc/blob/main/changelog.md) for new commands, deprecation removals, etc
 - [ ] Update lua-types if needed by inspecting the diff of [lua-filters.md](https://github.com/jgm/pandoc/commits/main/doc/lua-filters.md)
+- [ ] Check [`quarto-dev/quarto`](https://github.com/quarto-dev/quarto) (the visual-editor / VS Code tooling repo) for roundtrip **snapshot** test breakage on the next **prerelease**. Pandoc Markdown-*writer* changes — e.g. display-math newline handling, bullet/definition-list indentation — change visual-editor roundtrip output and break `apps/vscode/src/test/examples/generated_snapshots/*.qmd`. If output changed, open a companion PR there to regenerate the affected snapshots. Before regenerating, confirm each change is *intended* Pandoc behavior and not a transient regression (a bad snapshot can freeze a bug — see [quarto-dev/quarto#944](https://github.com/quarto-dev/quarto/pull/944)). Cross-ref: [`cross-project-dependencies.md`](cross-project-dependencies.md).

tests/smoke/smoke-all.test.ts

@@ -158,7 +158,10 @@ interface QuartoInlineTestSpec {
   verifyFns: Verify[];
 }
 
-// Functions to cleanup leftover testing
+// Functions to cleanup leftover testing.
+// postRenderCleanupFiles is a module-global list swept by EVERY render
+// teardown, so a registered entry only logs/removes at the teardowns where the
+// file actually exists (its owning document), not on every subsequent teardown.
 const postRenderCleanupFiles: string[] = [];
 function registerPostRenderCleanupFile(file: string): void {
   postRenderCleanupFiles.push(file);
@@ -168,8 +171,8 @@ const postRenderCleanup = () => {
     return;
   }
   for (const file of postRenderCleanupFiles) {
-    console.log(`Cleaning up ${file} in ${Deno.cwd()}`);
     if (safeExistsSync(file)) {
+      console.log(`Cleaning up ${file} in ${Deno.cwd()}`);
       // recursive so a registered entry can be a directory (e.g. an embedded
       // notebook's `*_files` support dir), not just a single file
       safeRemoveSync(file, { recursive: true });