Repository navigation
Commit 3a689f2
authored
Report runtime boundary increases a PR has already accepted as notices (#15183)
The PR-mode runtime boundary check compared the merge result only with
the base branch's baseline, so a PR that had already run
--update-baseline --accept-increase still got a warning for each new
call and the maintainer block. See #15180, where six new Deno calls
were accepted in the PR's baseline and still reported as pending.
- Read the working-tree baseline in PR mode. An increase the PR raised
there, and that the merge result does not exceed, is a notice listed
under "Accepted in this PR".
- Keep the warnings when the base baseline has room the PR did not
take, or when the merge result is now above the accepted count.
- Leave errors for Deno APIs that src/deno_ral replaces unchanged.
Related to #151531 parent 993caf3 commit 3a689f2
3 files changed
Lines changed: 115 additions & 5 deletions
File tree
- .github/workflows
- tests/unit/tools
- tools
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
661 | 662 | | |
662 | 663 | | |
663 | 664 | | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
664 | 735 | | |
665 | 736 | | |
666 | 737 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
501 | 502 | | |
502 | 503 | | |
503 | 504 | | |
| 505 | + | |
504 | 506 | | |
505 | 507 | | |
506 | 508 | | |
| |||
514 | 516 | | |
515 | 517 | | |
516 | 518 | | |
517 | | - | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
518 | 522 | | |
519 | 523 | | |
520 | 524 | | |
521 | 525 | | |
| 526 | + | |
522 | 527 | | |
523 | 528 | | |
524 | 529 | | |
| 530 | + | |
525 | 531 | | |
526 | 532 | | |
527 | 533 | | |
528 | 534 | | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
529 | 543 | | |
530 | 544 | | |
531 | 545 | | |
| |||
542 | 556 | | |
543 | 557 | | |
544 | 558 | | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
545 | 567 | | |
546 | 568 | | |
547 | 569 | | |
| |||
591 | 613 | | |
592 | 614 | | |
593 | 615 | | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
594 | 628 | | |
595 | 629 | | |
596 | 630 | | |
| |||
610 | 644 | | |
611 | 645 | | |
612 | 646 | | |
| 647 | + | |
613 | 648 | | |
614 | 649 | | |
615 | 650 | | |
| |||
838 | 873 | | |
839 | 874 | | |
840 | 875 | | |
841 | | - | |
| 876 | + | |
842 | 877 | | |
843 | 878 | | |
844 | 879 | | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
845 | 883 | | |
846 | 884 | | |
847 | 885 | | |
| |||
0 commit comments