Repository navigation
Commit 67893c6
authored
Make the runtime boundary check blame only a PR's own increase (#15153)
Pull request runs now compare against the base branch, so a PR is judged
on its own change. Comparing absolute counts blamed every open PR for an
increase merged to main by another PR (#15136 after #15134). The check
nets increases out per Deno API and per std module before any file is
blamed, so a renamed file or a moved call is not a finding.
An increase is an error only for a Deno API that src/deno_ral covers
equivalently (build.os and build.arch, in scopes that can import it).
Every other increase is a warning on the added line, and the job
summary gives the per-scope delta and the baseline bump a maintainer
accepts with --accept-increase. Std imports get only a suggested
replacement, since a name check cannot show that a wrapper exports what
the file uses. Pushes to main and manual runs keep the absolute baseline
gate.
- Delta mode reads the baseline committed at the base revision. A PR
that adds nothing while main is above baseline gets only a notice.
- Delta mode lists the whole base tree rather than passing every changed
path to git, which keeps long comparisons under the Windows
command-line limit.
- Counts use a prototype-free dictionary, so an identifier such as
constructor is an ordinary key.
- src/core/lib is browser-shared and cannot import src/deno_ral, so an
increase there is a warning, not an error.
Related to #15134, #15135 and #15136.1 parent 4b29a10 commit 67893c6
10 files changed
Lines changed: 1475 additions & 63 deletions
File tree
- .github/workflows
- dev-docs/runtime-migration
- tests/unit/tools
- tools
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
5 | 9 | | |
6 | 10 | | |
7 | 11 | | |
| |||
34 | 38 | | |
35 | 39 | | |
36 | 40 | | |
| 41 | + | |
| 42 | + | |
37 | 43 | | |
38 | 44 | | |
39 | 45 | | |
| |||
45 | 51 | | |
46 | 52 | | |
47 | 53 | | |
| 54 | + | |
| 55 | + | |
48 | 56 | | |
49 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| |||
310 | 310 | | |
311 | 311 | | |
312 | 312 | | |
313 | | - | |
| 313 | + | |
314 | 314 | | |
315 | 315 | | |
316 | 316 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
4 | 6 | | |
5 | 7 | | |
| |||
0 commit comments