Scope tarball retention cap to the intra-run build path

The previous commit put retention-days: 1 in the shared build-dist-tarball
action, but create-release.yml uses the same action to produce the "Deb Zip"
/ "Deb Arm64 Zip" release tarballs, and test-smokes-built.yml re-tests older
create-release runs via source=nightly / run-id. A 1-day cap there expires
the "Deb Zip" after a day, so re-testing a run older than that resolves
has-linux=false and silently skips the Linux smoke/playwright/ff-matrix legs
while Windows/Mac artifacts (uploaded elsewhere, still 90 days) keep the
run green.

Make retention a composite-action input defaulting to the repo default, and
cap it to 1 day only at the test-smokes-built build-mode call site, the sole
true intra-run transport. compression-level: 0 stays in the action - every
caller uploads an already-gzipped .tar.gz.

Author: cderv

.github/actions/build-dist-tarball/action.yml

@@ -19,6 +19,10 @@ inputs:
   artifact-name:
     description: "Workflow artifact name to upload the tarball as"
     required: true
+  retention-days:
+    description: "Artifact retention in days (empty = repo default; upload-artifact ignores an empty value)"
+    required: false
+    default: ""
 runs:
   using: "composite"
   steps:
@@ -51,8 +55,6 @@ runs:
       with:
         name: ${{ inputs.artifact-name }}
         path: ./package/${{ inputs.tarball-name }}
-        # intra-run transport only: legs of the same run download it minutes
-        # after upload; nothing reads it after the run
-        retention-days: 1
+        retention-days: ${{ inputs.retention-days }}
         # the tarball is already gzipped - re-compressing wastes CPU
         compression-level: 0

.github/workflows/test-smokes-built.yml

@@ -121,6 +121,9 @@ jobs:
           arch: amd64
           tarball-name: built-quarto-linux-amd64.tar.gz
           artifact-name: built-quarto-linux-amd64
+          # intra-run transport only: the smoke/playwright/ff-matrix legs of
+          # this run download it minutes later; nothing reads it afterward
+          retention-days: 1
 
   run-smokes-artifact:
     name: Smoke tests against built artifact