Skip to content

Commit b121dbb

Browse files
committed
runtime-migration: backport checklist decides the reverse codemod from the target's fs.ts
1.11 shipped before the Phase 1 codemods, so a v1.11 backport needs the reverse-codemod patch just like v1.10. Naming "v1.10 and earlier" would send a v1.11 backport down the plain cherry-pick path; the condition is now the target branch's src/deno_ral/fs.ts. The recipe was re-run on the fs.ts commit against v1.11 and the patch applies cleanly.
1 parent 9863de7 commit b121dbb

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

‎dev-docs/checklist-backport-a-pr.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ We backport development PRs to the stable branch using the following steps:
88
- Cherry-pick the commits from the development branch:
99
- `git cherry-pick <commit>` for every commit identified above.
1010
- Resolve conflicts as needed.
11-
- If the stable branch predates the runtime-layer codemods (v1.10 and earlier: `src/deno_ral/fs.ts` there has no `readTextFileSync`) and a commit touches TypeScript, cherry-picking conflicts wherever its context lines were codemodded. Build the patch in the stable branch's `Deno.*` form instead, from the `main` checkout:
11+
- If the stable branch predates the runtime-layer codemods (`src/deno_ral/fs.ts` there has no `readTextFileSync`; decide from that file, not the release number: v1.11 and earlier all qualify) and a commit touches TypeScript, cherry-picking conflicts wherever its context lines were codemodded. Build the patch in the stable branch's `Deno.*` form instead, from the `main` checkout:
1212

1313
```bash
1414
c=<commit>

‎dev-docs/runtime-migration/09-ral-fs-and-temp-layer.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2722,3 +2722,9 @@ Seven review rounds on the forward guard that skips files patching `Deno.*` (for
27222722
- `deno types`: `SymlinkOptions.type` is still required and `truncateSync(name: string, …)` still string-only, so the Task 3 adaptations stand; both README rows now say they hold on 2.9.8.
27232723
- ral suite → `ok | 23 passed | 0 failed | 1 ignored`; smoke trio → `ok | 7 passed | 0 failed | 2 ignored`; no warnings in either log. No PR 09 check relies on test sanitizers (off by default in Deno 2.9).
27242724
- Forward dry run (`--rules fs,temp,env,process,platform --dir src --dry-run`) → `624 files scanned, 224 would be rewritten, 816 replacements, 18 with collisions, 2 skipped`, unchanged; `git status --short src` empty.
2725+
2726+
### Rebase onto the release reconciliation (`708e443aa`, 2026-11-03)
2727+
2728+
- Only README and HANDOFF conflicted: `main`'s sequence row 09 and HANDOFF status lines were kept as written there; its new "Open decisions" rows were kept, with the two PR 09 Task 3 rows in their 2.9.8 wording.
2729+
- README row "PRs 09, 10 and 37, backports" asks this PR's backport checklist to cover `v1.11`. `upstream/v1.11` (`c5fc6c50e`, Deno 2.9.8) has no `readTextFileSync` in `src/deno_ral/fs.ts`, so it predates the codemods like `v1.10`. `dev-docs/checklist-backport-a-pr.md` no longer says "v1.10 and earlier": the condition is the target branch's `fs.ts`, with v1.11 and earlier named as qualifying (the Task 5 Step 3 text above still says v1.10).
2730+
- The checklist recipe re-run as written on this PR's `fs.ts` commit (`5b7cd9e65`) against `upstream/v1.11`: reverse at the new revision → `1 rewritten, 49 replacements, 1 left` (`canonicalPathSync`, with the `originalRealPathSync` hint); `git apply --check` exit 0 and `git apply -3 --check` exit 0 (`Applied patch to 'src/deno_ral/fs.ts' cleanly`, three-way falls back to direct application for the new test file).

0 commit comments

Comments
 (0)