Repository navigation
Commit fd40c94
authored
Fix revealjs speaker view Layout test on macOS (#15231)
The test pressed ArrowDown on the focused Layout select and expected the
value to become wide. On macOS, Chromium, WebKit and Firefox all open the
popup on ArrowDown or ArrowUp over a closed select instead of changing the
value (Blink and WebKit through PopsMenuByArrowKeys on the Mac theme,
Gecko through its XP_MACOSX branch in HTMLSelectEventListener). The value
stayed default, so the nightly macOS Playwright job failed in all three
browsers while Linux and Windows passed.
The test checks two things that do not need the same key. The value,
its visible label and the accessible name are now set and checked with
selectOption. The arrow key press stays, followed by the existing check
that the deck does not move, without asserting the value afterwards. The
keydown still reaches the select on macOS, so the speaker view's guard
against forwarding keys from native controls is still exercised there.
Removing that guard from the rendered speaker view makes the test fail
on the deck position check in chromium, firefox and webkit, so the
remaining assertion still catches the regression it was written for.
This is a characterization fix: no macOS runner was available locally,
and the macOS result will come from the next nightly run.1 parent 60efc6e commit fd40c94
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
28 | 31 | | |
29 | 32 | | |
30 | 33 | | |
| |||
0 commit comments