Repository navigation
Description
Observed behavior
I was testing revealjs/update-v5 branch in dev quarto-cli to render our demo slides at https://quarto.org/docs/presentations/revealjs/demo/
This new branch is using revealjs 5.1.0 and I would have expected this to be used.
cd quarto-web
# doing incremental render
quarto render .\docs\presentations\revealjs\demo\index.qmd
Dependency in site_libs was updated
❯ grep -2 "revealjs[.]com" .\_site\site_libs\revealjs\dist\reveal.js
/*!
* reveal.js 5.1.0
* https://revealjs.com
* MIT licensed
*But freezer is still using old version
❯ grep -2 "revealjs[.]com" .\_freeze\site_libs\revealjs\dist\reveal.js
/*!
* reveal.js 4.3.1
* https://revealjs.com
* MIT licensed
*which implies that with freeze: true in our quarto-web project when doing
quarto render
the freezer is used for site_libs it seems, and the old revealjs is used... After quarto render I get
❯ grep -2 "revealjs[.]com" .\_site\site_libs\revealjs\dist\reveal.js
/*!
* reveal.js 4.3.1
* https://revealjs.com
* MIT licensed
*
back to old one.
If I delete the file, then the new version is put in freezer.
So I believe this is a conflict similar to our "different themes in websites", but when using freeze. All the revealjs presentation in the website are using same file in site_libs/.
It seems site_libs in the freezer will always win. So it needs to be updated somehow.
I need to understand this, and see what is the recommended way : Manuel invalidation or a fix in our site_libs handling...
Activity
cderv commentedon Jul 26, 2024
And it seems we also have another copy of the dependency in
.quartoproject hidden folderNot sure how it behave when new updated quarto with new revealjs update is used. 🤔
I'll try to build an easier example to investigate all this...
cderv commentedon Jul 26, 2024
right now I can't reproduce on a simple website... It happens only inside quarto-web
cscheid commentedon Jul 26, 2024
I wouldn't touch the freeze implementation without a longer discussion with @jjallaire and @dragonstyle; there's a lot of corner cases involved.
cderv commentedon Oct 18, 2024
And we are hitting the problem in
I added new feature in
quarto-supportplugin, which requires an updated version of this plugin, and quarto-web still have the old version in freeze, which is used despite doing incremental rendering.So we definitely have something going that is not great experience. I think I can solve in Quarto web by rerendering every presentations, or removing the revealjs folder from freeze.
Re-render with Revealjs 5 to update freeze
cscheid commentedon Oct 18, 2024
Let's have a discussion about this early in 1.7.
cderv commentedon Oct 29, 2024
Just referencing another occurence of this
v1.6 is updating
quarto-listing.jsfollowing #11177 - this change was not reflected in quarto-web until an incrementalquarto renderis ran on one of the blog post.Though in the meantime, other change like .ejs template where applying and so old
quarto-listing.jswas no more adequate, leading to breakage in #11230.Again, not great... we should have a way for quarto when rendered with a new version to tell the freezer site_libs to be updated when we known it needs to 🤔
cscheid commentedon May 15, 2025
In order to fix this, we need to change our freezer implementation to record more information.
chore: refresh frozen revealjs site_libs for Quarto 1.12.1 (#2346)
chore: refresh frozen revealjs site_libs for Quarto 1.12.1 (#2346) (#…
cderv commentedon Nov 6, 2026
Hit this again with Quarto 1.12.1, and it reproduces on a simple website, which I could not get earlier in this thread.
Minimal project:
_quarto.ymlwithproject: {type: website, output-dir: _site}andexecute: {freeze: true}, oneengine: knitrpage with an R chunk (so it gets a freezer entry), and oneformat: revealjspage. Runquarto render, then append a line to_freeze/site_libs/revealjs/plugin/quarto-line-highlight/line-highlight.jsand runquarto renderagain. The appended line shows up in_site/site_libs/revealjs/plugin/quarto-line-highlight/line-highlight.js, so the freezer copy wins over the files Quarto just generated.This is the part of
render-files.tsthat copiessite_libsfrom the freezer over the output libs as soon as a frozen page is thawed:quarto-cli/src/command/render/render-files.ts
Lines 194 to 198 in a2ebc79
So the freezer keeps whatever revealjs runtime was committed, whatever the Quarto version doing the render.
In quarto-web, the preview of a new revealjs option rendered with 1.12.1 showed the wrong behaviour because the committed freezer had an old
line-highlight.js. quarto.org and prerelease.quarto.org were serving that same old file. I worked around it by regenerating_freeze/site_libs/revealjsfrom a 1.12.1 render in quarto-dev/quarto-web#2346.On recording more information in the freezer: we could stamp the frozen
site_libswith the Quarto version that wrote them, and drop them when it differs from the rendering version. @cscheid does that match what you had in mind, or are there corner cases it misses?