Repository navigation
Conversation
Fixes quarto-dev#15176 Signed-off-by: Don Yin <Don_Yin@outlook.com>
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15176.
quarto-listing.scssopened its variables with/*-- scss:variables --*/, which is not a layer boundary, so they stayed in the functions layer and were set before the theme's!defaultvalues. I changed it to/*-- scss:defaults --*/.The same thing overrode the grays and border color of the Bootswatch themes. I rendered a website with each built-in theme before and after, and its
:rootcolors now match a standalone document with the same theme (slate, for example, no longer gets light#dee2e6borders). The border radius stays at the listing's0.25remunless the theme sets one.The new smoke-all test fails on
mainand passes with the change, and thesmoke/sitetests pass.Disclosure: I used Pi with Claude Code.
Checklist
I have (if applicable):
AI-assisted PR
Note: autonomous AI agents submitting PRs without human oversight are not permitted — see the Code of Conduct.