Skip to content

Fix listing styles overriding theme defaults in websites - #15197

Open
Don-Yin wants to merge 1 commit into
quarto-dev:mainfrom
Don-Yin:fix-15176-listing-defaults
Open

Don-Yin wants to merge 1 commit into
quarto-dev:mainfrom
Don-Yin:fix-15176-listing-defaults

Conversation

@Don-Yin

@Don-Yin Don-Yin commented Oct 26, 2026

Copy link
Copy Markdown

Description

Fixes #15176.

quarto-listing.scss opened its variables with /*-- scss:variables --*/, which is not a layer boundary, so they stayed in the functions layer and were set before the theme's !default values. I changed it to /*-- scss:defaults --*/.

The same thing overrode the grays and border color of the Bootswatch themes. I rendered a website with each built-in theme before and after, and its :root colors now match a standalone document with the same theme (slate, for example, no longer gets light #dee2e6 borders). The border radius stays at the listing's 0.25rem unless the theme sets one.

The new smoke-all test fails on main and passes with the change, and the smoke/site tests pass.

Before and after applying the patch

Disclosure: I used Pi with Claude Code.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog in the PR
  • ensured the present test suite passes
  • added new tests
  • created a separate documentation PR in Quarto's website repo and linked it to this PR
AI-assisted PR
  • AI tool used: Pi with Claude Code
  • Codebase grounding: local clone
  • Human review: I have reviewed, tested, and verified the AI-generated content before submitting.

Note: autonomous AI agents submitting PRs without human oversight are not permitted — see the Code of Conduct.

Fixes quarto-dev#15176

Signed-off-by: Don Yin <Don_Yin@outlook.com>
@posit-snyk-bot

posit-snyk-bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Website projects ignore $border-color and $border-radius defaults because of an invalid scss:variables boundary in quarto-listing.scss

2 participants