Repository navigation
Conversation
…ackdrop On narrow screens the secondary bar click area and #quarto-sidebar-glass were collapse triggers too, so Bootstrap wrote aria-expanded on them. Have both forward clicks to the real toggle button instead. Fixes quarto-dev#15229
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15229.
On narrow screens the secondary-bar click area (
a.flex-grow-1) and#quarto-sidebar-glasswere bothdata-bs-toggle="collapse"triggers, so Bootstrap wrotearia-expandedon them when the sidebar toggled, and axe flaggedaria-allowed-attr.This drops
data-bs-toggle/data-bs-targetfrom both and has them.click()the real.quarto-btn-toggleinstead. The button already callsquartoToggleHeadroom(), so the inline call on the click area goes away, and closing via the backdrop now resets headroom as well.Added a small website fixture and a Playwright spec (
html-sidebar-collapse-aria.spec.ts) that opens the sidebar via the button and via the click area, checks that only the button hasaria-expanded, and checks that tapping the backdrop closes it and resets the button tofalse. It fails onmainand passes with this change (chromium, locally).Checklist
I have (if applicable):