Skip to content

Let captioned tables break across pages in Typst #15278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faysou wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Let captioned tables break across pages in Typst #15278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/changelog-1.12.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ All changes included in 1.12:

- ([#15168](https://github.com/quarto-dev/quarto-cli/issues/15168)): Fix definitions, examples and exercises being set in italics in Typst output with the default `theorem-appearance: simple`. Their body is now upright, as in LaTeX output, while theorems, lemmas, corollaries, propositions and conjectures keep an italic body. (author: @mcanouil)
- ([#15251](https://github.com/quarto-dev/quarto-cli/pull/15251)): Fix algorithm blocks (`#alg-`) being set in italics with `theorem-appearance: simple` and using the colours of theorems with `theorem-appearance: fancy`. They now look like definitions, examples and exercises. (author: @mcanouil)
- ([#15278](https://github.com/quarto-dev/quarto-cli/pull/15278)): Fix captioned tables taller than a page being cut off instead of continuing on the next page. (author: @faysou)

## Projects

Expand Down
2 changes: 2 additions & 0 deletions src/resources/formats/typst/pandoc/quarto/definitions.typ
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
#block(inset: (left: 1.5em, top: -0.4em))[#it.description]
]

#show figure.where(kind: "quarto-float-tbl"): set block(breakable: true)

// Some quarto-specific definitions.

#show raw.where(block: true): set block(
Expand Down
93 changes: 93 additions & 0 deletions tests/docs/smoke-all/typst/table-figure-breakable.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
---
title: Long captioned table breaks across pages
format: typst
_quarto:
tests:
typst:
ensurePdfTextPositions:
- # The table is taller than a page. A breakable figure starts on
# page 1 below the title; an unbreakable one moves whole to page 2
# and its last rows run past the page bottom.
- subject: "FIRSTROW_MARKER"
relation: above
object:
role: Page
page: 1
edge: bottom
- []
---

| A | B |
|---|---|
| 1 | FIRSTROW_MARKER |
| 2 | row 2 |
| 3 | row 3 |
| 4 | row 4 |
| 5 | row 5 |
| 6 | row 6 |
| 7 | row 7 |
| 8 | row 8 |
| 9 | row 9 |
| 10 | row 10 |
| 11 | row 11 |
| 12 | row 12 |
| 13 | row 13 |
| 14 | row 14 |
| 15 | row 15 |
| 16 | row 16 |
| 17 | row 17 |
| 18 | row 18 |
| 19 | row 19 |
| 20 | row 20 |
| 21 | row 21 |
| 22 | row 22 |
| 23 | row 23 |
| 24 | row 24 |
| 25 | row 25 |
| 26 | row 26 |
| 27 | row 27 |
| 28 | row 28 |
| 29 | row 29 |
| 30 | row 30 |
| 31 | row 31 |
| 32 | row 32 |
| 33 | row 33 |
| 34 | row 34 |
| 35 | row 35 |
| 36 | row 36 |
| 37 | row 37 |
| 38 | row 38 |
| 39 | row 39 |
| 40 | row 40 |
| 41 | row 41 |
| 42 | row 42 |
| 43 | row 43 |
| 44 | row 44 |
| 45 | row 45 |
| 46 | row 46 |
| 47 | row 47 |
| 48 | row 48 |
| 49 | row 49 |
| 50 | row 50 |
| 51 | row 51 |
| 52 | row 52 |
| 53 | row 53 |
| 54 | row 54 |
| 55 | row 55 |
| 56 | row 56 |
| 57 | row 57 |
| 58 | row 58 |
| 59 | row 59 |
| 60 | row 60 |
| 61 | row 61 |
| 62 | row 62 |
| 63 | row 63 |
| 64 | row 64 |
| 65 | row 65 |
| 66 | row 66 |
| 67 | row 67 |
| 68 | row 68 |
| 69 | row 69 |
| 70 | row 70 |

: Long table {#tbl-long}
96 changes: 96 additions & 0 deletions tests/docs/smoke-all/typst/table-figure-unbreakable-override.qmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
---
title: Header include keeps a long captioned table whole
format:
typst:
include-in-header:
text: |
#show figure.where(kind: "quarto-float-tbl"): set block(breakable: false)
_quarto:
tests:
typst:
ensurePdfTextPositions:
- []
- # The header rule overrides the breakable default, so the
# unbreakable figure moves whole to page 2.
- subject: "FIRSTROW_MARKER"
relation: above
object:
role: Page
page: 1
edge: bottom
---

| A | B |
|---|---|
| 1 | FIRSTROW_MARKER |
| 2 | row 2 |
| 3 | row 3 |
| 4 | row 4 |
| 5 | row 5 |
| 6 | row 6 |
| 7 | row 7 |
| 8 | row 8 |
| 9 | row 9 |
| 10 | row 10 |
| 11 | row 11 |
| 12 | row 12 |
| 13 | row 13 |
| 14 | row 14 |
| 15 | row 15 |
| 16 | row 16 |
| 17 | row 17 |
| 18 | row 18 |
| 19 | row 19 |
| 20 | row 20 |
| 21 | row 21 |
| 22 | row 22 |
| 23 | row 23 |
| 24 | row 24 |
| 25 | row 25 |
| 26 | row 26 |
| 27 | row 27 |
| 28 | row 28 |
| 29 | row 29 |
| 30 | row 30 |
| 31 | row 31 |
| 32 | row 32 |
| 33 | row 33 |
| 34 | row 34 |
| 35 | row 35 |
| 36 | row 36 |
| 37 | row 37 |
| 38 | row 38 |
| 39 | row 39 |
| 40 | row 40 |
| 41 | row 41 |
| 42 | row 42 |
| 43 | row 43 |
| 44 | row 44 |
| 45 | row 45 |
| 46 | row 46 |
| 47 | row 47 |
| 48 | row 48 |
| 49 | row 49 |
| 50 | row 50 |
| 51 | row 51 |
| 52 | row 52 |
| 53 | row 53 |
| 54 | row 54 |
| 55 | row 55 |
| 56 | row 56 |
| 57 | row 57 |
| 58 | row 58 |
| 59 | row 59 |
| 60 | row 60 |
| 61 | row 61 |
| 62 | row 62 |
| 63 | row 63 |
| 64 | row 64 |
| 65 | row 65 |
| 66 | row 66 |
| 67 | row 67 |
| 68 | row 68 |
| 69 | row 69 |
| 70 | row 70 |

: Long table {#tbl-long}
Loading