Repository navigation
Translate the Korean and Serbian (Latin) leftover language keys with reviewed machine translation - #15292
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…reviewed machine translation The language parity test lists one Korean key (`title-block-modified`) and five Serbian (Latin) keys (`code-links-title`, `launch-binder-title`, `launch-dev-container-title`, `listing-page-field-wordcount`, `listing-page-words`) as missing, so those strings fell back to English. Each value comes from a machine translation service with a per-key context and was accepted only after two independent AI reviewers, working blind from each other, agreed on it. For two values both reviewers flagged the machine output with the same replacement, and the replacement is what is committed: Korean `title-block-modified` follows the noun form of `title-block-published`, and Serbian `code-links-title` follows the title casing of the file's other headings. "Binder" and "Dev Container" stay untranslated as product names.
cderv
force-pushed
the
feature/l10n-ko-srlatn-leftovers
branch
from
November 4, 2026 14:55
3755928 to
e718450
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six language keys have a translation in every other base language but not in one:
title-block-modifiedin Korean (the "Modified" label in a document's title block), andcode-links-title,launch-binder-title,launch-dev-container-title,listing-page-field-wordcountandlisting-page-wordsin Serbian (Latin) (the code links heading and its two launch links, and the word count column label and value in listings). On a Korean or Serbian (Latin) page those strings show in English. This fills them as planned in #14822 (comment), in one PR because there is no per-key sub-issue to track. It follows the per-key PRs merged earlier, such as #15284 and #15285.How the values were made
Every value below is AI-generated, not written by a native speaker.
Each key got a machine translation with a per-key context describing where the string appears and what it means: a date label in the same form as
title-block-publishedfor Korean, a short imperative for the two launch links, a plural noun phrase for the heading, a quantity label for the column, and a count with a plural noun forlisting-page-words(one string serves every count). The same language file's related strings were passed for vocabulary. "Binder" and "Dev Container" are product names and stay untranslated. Two independent AI reviewers then checked the values without seeing each other's output. For Serbian (Latin) they also got the same key insl,sk,csandplas a reference only (plwas left out forlisting-page-field-wordcount, whose Polish value reads as a counter tool). A value is committed only when both accept it, or both propose the same correction.title-block-modifiedcode-links-titlelaunch-binder-titlelaunch-dev-container-titlelisting-page-field-wordcountlisting-page-wordsTwo values are not the machine translation as returned. For Korean, the service returned "수정됨", a past-participle form, and both reviewers proposed the bare noun "수정" independently, which matches
title-block-published("공개"). Forcode-links-title, the service returned "Linkovi ka kodu" and both reviewers proposed title casing, "Linkovi ka Kodu", like the file's other headings ("Drugi Linkovi", "Izvorni Kod"). The other four are the machine translation as returned, accepted by both reviewers.Not filled
tools-downloadfor Serbian (Latin) is a different key and stays intests/unit/language-known-gaps.yml; this PR does not touch it.I rendered a website with
lang: sr-Latncontaining a listing with the word count field, and a page with Binder and Dev Container code links, and a Korean page withdate-modified. The listing shows "1 500 reči" under the column "Broj reči" with no literal{0}, the code links list shows "Linkovi ka Kodu", "Pokreni Binder" and "Pokreni Dev Container", and the Korean title block shows "공개" and "수정" side by side. The evidence will be on #14822.Native speakers are welcome to improve any of these values.
Part of #14822
Checklist
I have (if applicable):
AI-assisted PR
Note: autonomous AI agents submitting PRs without human oversight are not permitted — see the Code of Conduct.