Repository navigation
Align verify-l10n-pr skill with the language parity workflow - #15309
Merged
Merged
Conversation
The skill predates the language parity test and the per-key reviewed machine translation procedure of #14822. Landing the Arabic PR showed what it missed: it checked against the PR's base, so keys added to _language.yml while the PR waited went unnoticed until CI; it never looked for a second open PR on the same file; and it had no procedure for filling those keys or finishing a stale community PR. It now checks against main and names the parity test as the gate, starts with a duplicate and open-question pass, adds the fill procedure as a reference (translator note as context, two blind reviewers, commit only agreed values, otherwise a known gap), and lists the finishing steps maintainers used for recent language PRs. The stale line reference to the landmark-label note now names the note instead.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
verify-l10n-prskill (#14880) predates the language parity test from #15265 and the per-key reviewed machine translation done for #14822. Using it to land the Arabic localization (#14389) showed three gaps:_language.ymlof the PR's base, so the 11 keys added onmainwhile the PR waited were not reported, although the parity test fails on them.The skill now runs in five steps: duplicates and open questions on the thread, structure against
mainwith the parity test as the merge gate, review of the contributor's values, filling missing keys, and finishing the PR.The fill procedure is a new reference,
references/fill-missing-keys.md. Each key is machine translated with its translator note from_language.ymlas context, two reviewers check the values without seeing each other's output, and only values both accept are committed. Anything else goes on the known-gaps list for a native speaker. The finishing steps are the ones used on #15225 and #14389: maintainer fixup with the changelog entry, native-speaker suggestions applied with aCo-authored-bytrailer, and machine-translated values listed in the PR with an AI-generated disclosure.A reference to the landmark-label rule by line number in
_language.ymlhad drifted, it now names the translator note instead.Related to #14822
Checklist
I have (if applicable):
AI-assisted PR
Note: autonomous AI agents submitting PRs without human oversight are not permitted — see the Code of Conduct.