Skip to content

chore: refresh frozen revealjs site_libs for Quarto 1.12.1 - #2346

Merged
cderv merged 1 commit into
mainfrom
chore/refresh-revealjs-freeze-main
Nov 6, 2026
Merged

cderv merged 1 commit into
mainfrom
chore/refresh-revealjs-freeze-main

Conversation

@cderv

@cderv cderv commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

The live sites serve an old reveal.js line-highlight plugin even though they are rendered with Quarto 1.12.1. quarto.org and prerelease.quarto.org both deliver a line-highlight.js that is byte-identical to the copy tracked in _freeze/site_libs/revealjs, not to the one shipped in 1.12.1. It showed up in the deploy preview of #2340, where the code-line-fragment-indices example ran the highlight steps in the wrong order.

With freeze: true, rendering a page that has frozen results copies _freeze/site_libs over the freshly generated site_libs. The revealjs runtime tracked there wins over the one from the Quarto version doing the render, see quarto-dev/quarto-cli#10391. The tracked copy predated 1.12.1: reveal.js core, the notes, quarto-support and reveal-menu plugins, and the line-highlight plugin all differed from a fresh 1.12.1 render. Both publish jobs render with the latest prerelease, and main and prerelease carry the same freezer tree, so one refresh covers both.

_freeze/site_libs/revealjs was deleted and the five frozen revealjs pages were re-rendered with 1.12.1, so the freezer regenerates it. The frozen results of those pages are unchanged: re-executing them only altered random widget ids and figure bytes.

Test Plan

  • line-highlight.js in _freeze/site_libs/revealjs is identical to the file in the Quarto 1.12.1 release
  • Deploy preview of this PR serves that same line-highlight.js
  • After merge and publish, quarto.org serves it too
  • After the port to prerelease, /deploy-preview on docs(revealjs): document code-line-fragment-indices #2340 shows note 1, line 1, note 2, line 2 on the example 5 slide

Related to quarto-dev/quarto-cli#10391

Rendering a project with `freeze: true` copies `_freeze/site_libs` over the freshly generated `site_libs` whenever a frozen page is thawed, so the revealjs runtime tracked in the freezer wins over the one shipped with the Quarto version doing the render (quarto-dev/quarto-cli#10391).

The tracked copy predated 1.12.1: reveal.js core, the notes, quarto-support and reveal-menu plugins, and the line-highlight plugin differed from a fresh 1.12.1 render. As a result a preview rendered with 1.12.1 still shipped the old line-highlight plugin, which ignores `code-line-fragment-indices`.

Regenerated by deleting `_freeze/site_libs/revealjs` and re-rendering the five frozen revealjs pages with Quarto 1.12.1 and the prerelease-docs profile. The frozen results of those pages are unchanged: re-executing them only altered random widget ids and figure bytes, so they were left as they were.
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

📝 Preview Deployment

🔍 Full site preview: https://deploy-preview-2346.quarto.org

@cderv
cderv merged commit 5251a75 into main Nov 6, 2026
4 checks passed
@cderv
cderv deleted the chore/refresh-revealjs-freeze-main branch November 6, 2026 18:40
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Successfully created backport PR for prerelease:

github-actions Bot added a commit that referenced this pull request Nov 6, 2026
…2347)

Rendering a project with `freeze: true` copies `_freeze/site_libs` over the freshly generated `site_libs` whenever a frozen page is thawed, so the revealjs runtime tracked in the freezer wins over the one shipped with the Quarto version doing the render (quarto-dev/quarto-cli#10391).

The tracked copy predated 1.12.1: reveal.js core, the notes, quarto-support and reveal-menu plugins, and the line-highlight plugin differed from a fresh 1.12.1 render. As a result a preview rendered with 1.12.1 still shipped the old line-highlight plugin, which ignores `code-line-fragment-indices`.

Regenerated by deleting `_freeze/site_libs/revealjs` and re-rendering the five frozen revealjs pages with Quarto 1.12.1 and the prerelease-docs profile. The frozen results of those pages are unchanged: re-executing them only altered random widget ids and figure bytes, so they were left as they were.

(cherry picked from commit 5251a75)

Co-authored-by: Christophe Dervieux <christophe.dervieux@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant