Repository navigation
Bump vscode-languageserver and vscode-languageclient to 11 - #1223
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces those two Dependabot PRs that bump vscode-languageserver and vscode-languageclient from 10.1.2 to 11.0.0 separately.
LSP features are working correctly:
The two packages come from the same
vscode-languageserver-noderepository and sharevscode-languageserver-protocol,vscode-jsonrpc, andvscode-languageserver-types. Each Dependabot PR alone adds a nested copy of these shared packages, because the other package still uses the old versions at the top level. This PR bumps both packages together, so the lockfile has one copy of each:vscode-languageserverandvscode-languageclient: 10.1.2 to 11.0.0vscode-languageserver-protocolandvscode-languageserver-types: 3.18.4 to 3.18.5vscode-jsonrpc: 9.0.3 to 10.0.0vscode-languageserver-textdocument: 1.0.15 to 1.0.16The PR also raises the
vscode-languageserver-typesfloor to^3.18.5in each workspace that declares it.The PR adds a
vscode-languageserver-nodegroup to.github/dependabot.ymlso that all future bumps of these packages come in one PR, for major, minor, and patch updates. The group comes beforenpm-minor-and-patch, because Dependabot puts a dependency in the first group that matches it.The lockfile diff contains only these packages. I did not run
npm dedupe, because it also updates unrelated packages.