fix: align update operation delete api

Signed-off-by: immanuwell <pchpr.00@list.ru>

Author: immanuwell

Documentation/reference/api.md

@@ -250,12 +250,16 @@ def responses($r):
         ],
       },
     },
-    "\($path_match)/internal/update_operation/{digest}": {
+    "\($path_match)/internal/update_operation/{id}": {
       delete: {
         operationId: "DeleteUpdateOperation",
-        responses: (responses({})),
+        responses: (responses({
+          "204": {
+            description: "Success",
+          },
+        }) | del(.["200"])),
       },
-      parameters: [ param_ref("digest") ],
+      parameters: [ param_ref("update_operation_id") ],
     },
     "\($path_match)/internal/update_diff": {
       get: {
@@ -349,6 +353,16 @@ def responses($r):
         in: "path",
         schema: schema_ref("digest"),
         required: true,
+      },
+      update_operation_id: {
+        description: "UUID of the update operation to delete.",
+        name: "id",
+        in: "path",
+        schema: {
+          type: "string",
+          format: "uuid",
+        },
+        required: true,
       }
     },
     headers: {

httptransport/api/v1/openapi.etag

@@ -239,15 +239,15 @@ func (h *MatcherV1) updateOperationHandlerDelete(w http.ResponseWriter, r *http.
 	id := filepath.Base(path)
 	uuid, err := uuid.Parse(id)
 	if err != nil {
-		slog.WarnContext(ctx, "could not deserialize manifest", "reason", err)
-		apiError(ctx, w, http.StatusBadRequest, "could not deserialize manifest: %v", err)
+		slog.WarnContext(ctx, "could not parse update operation id", "reason", err)
+		apiError(ctx, w, http.StatusBadRequest, "could not parse update operation id: %v", err)
 	}
 
 	_, err = h.srv.DeleteUpdateOperations(ctx, uuid)
 	if err != nil {
 		apiError(ctx, w, http.StatusInternalServerError, "could not get update operations: %v", err)
 	}
-	// TODO(hank) This should return HTTP 204.
+	w.WriteHeader(http.StatusNoContent)
 }
 
 func init() {

httptransport/api/v1/openapi.jq

@@ -346,7 +346,18 @@ func testUpdateOperationHandlerGet(t *testing.T) {
 	idStr := "\"" + id.String() + "\""
 	var called bool
 	var latestCalled bool
+	var deleteCalled bool
 	m := &matcher.Mock{
+		DeleteUpdateOperations_: func(_ context.Context, refs ...uuid.UUID) (int64, error) {
+			deleteCalled = true
+			if got, want := len(refs), 1; got != want {
+				t.Fatalf("got: %v, want: %v", got, want)
+			}
+			if got, want := refs[0], id; got != want {
+				t.Fatalf("got: %v, want: %v", got, want)
+			}
+			return 1, nil
+		},
 		LatestUpdateOperation_: func(context.Context, driver.UpdateKind) (uuid.UUID, error) {
 			return id, nil
 		},
@@ -411,4 +422,19 @@ func testUpdateOperationHandlerGet(t *testing.T) {
 	if etag != idStr {
 		t.Fatalf("got: %v, want: %v", etag, id.String())
 	}
+
+	req, err = httputil.NewRequestWithContext(ctx, http.MethodDelete, srv.URL+path.Join("/", "internal", "update_operation", id.String()), nil)
+	if err != nil {
+		t.Fatalf("failed to create request: %v", err)
+	}
+	resp, err = c.Do(req)
+	if err != nil {
+		t.Fatalf("failed to make request: %v", err)
+	}
+	if resp.StatusCode != http.StatusNoContent {
+		t.Fatalf("got: %v, want: %v", resp.StatusCode, http.StatusNoContent)
+	}
+	if !deleteCalled {
+		t.Fatalf("got: %v, want: %v", deleteCalled, true)
+	}
 }