Skip to content

cmd: fix compile failure when injected describe string is empty #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpitjain099 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

cmd: fix compile failure when injected describe string is empty #2477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func init() {
switch {
case Version != "":
// Had our version injected at build: do nothing.
case len(describe) > 0 && describe[0] != '$' && !strings.HasPrefix(describe, "%(describe:"):
case len(describe) > 0 && !strings.HasPrefix(describe, "$") && !strings.HasPrefix(describe, "%(describe:"):
// Some git versions apparently don't know about the describe format
// verb, so need to check that it's not just "%(describe..."
Version = describe
Expand Down