Skip to content

feat: Handle multiple network leaf pairs in vlan_group naming convention - #2187

Merged
stevekeay merged 2 commits into
mainfrom
vlan_group_names
Oct 5, 2026
Merged

stevekeay merged 2 commits into
mainfrom
vlan_group_names

Conversation

@stevekeay

@stevekeay stevekeay commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Release note:

This change will take effect on baremetal node inspection.

Any existing data should be updated before any nodes are inspected.

So for each of the devices in these cabs we should be updating the physical_network in the Ironic baremetal ports as well as the Neutron network segments.

In addition we should ensure that nautobot picks up those changes, fixing up if necessary.

If an OVN/OVS network node is in these cabs then we might need further updates, investigation would be required there to make sure we don't break any ovn bridge mappings. Envs where the infra nodes are connected to a "-2" switch, note the first two are already done:

/tmp/ports-iad3-advent-infra   infra1.iad3-advent   f8-41-2/f8-42-2-network │ f8-41-2.iad3 Ethernet1/17 [34:d8:68:da:2a:a0]
/tmp/ports-iad3-advent-infra   infra2.iad3-advent   f8-41-2/f8-42-2-network │ f8-41-2.iad3 Ethernet1/18 [34:d8:68:da:15:e0]
/tmp/ports-iad3-advent-infra   infra3.iad3-advent   f8-41-2/f8-42-2-network │ f8-41-2.iad3 Ethernet1/19 [00:62:0b:7c:49:50]
                                                   
/tmp/ports-ord1-advent-infra   infra1.ord1-advent   j2-29-2/j2-30-2-network │ j2-29-2.ord1 Ethernet1/34 [b4:83:51:03:2b:a2]
/tmp/ports-ord1-advent-infra   infra2.ord1-advent   j2-29-2/j2-30-2-network │ j2-29-2.ord1 Ethernet1/35 [b4:83:51:03:2b:52]
/tmp/ports-ord1-advent-infra   infra3.ord1-advent   j2-29-2/j2-30-2-network │ j2-29-2.ord1 Ethernet1/36 [b4:83:51:02:c6:b4]                                
                                                   
/tmp/ports-rxdb-infra-infra    infra1.iad3-rxdb-i   g6-5/g6-6-network       │ g6-5-2.iad3 Ethernet1/19 [b4:83:51:02:b3:2a]
/tmp/ports-rxdb-infra-infra    infra2-1378593-Del   g6-5/g6-6-network       │ g6-5-2.iad3 Ethernet1/38 [b4:83:51:03:2d:7c]
/tmp/ports-rxdb-infra-infra    infra3-1378594-Del   g6-5/g6-6-network       │ g6-5-2.iad3 Ethernet1/39 [b4:83:51:03:2c:ac]
                                                   
/tmp/ports-rxdb-mt-infra       infra1.iad3-rxdb-m   g6-7/g6-8-network       │ g6-7-2.iad3 Ethernet1/19 [b0:26:28:cc:9b:70]
/tmp/ports-rxdb-mt-infra       infra2.iad3-rxdb-m   g6-7/g6-8-network       │ g6-7-2.iad3 Ethernet1/41 [b0:26:28:73:9c:50]
/tmp/ports-rxdb-mt-infra       infra3.iad3-rxdb-m   g6-7/g6-8-network       │ g6-7-2.iad3 Ethernet1/42 [b0:26:28:73:9d:90]

@stevekeay
stevekeay requested a review from a team August 6, 2026 09:07
@stevekeay
stevekeay requested a review from a team August 7, 2026 14:55

@mfencik mfencik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cardoe

cardoe commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Given the new request for -3 switches. We need to revisit this.

@stevekeay

Copy link
Copy Markdown
Contributor Author

2724f39 already adds support for those. What do we need to revisit? Note that this is an interim solution anyhow.

@cardoe

cardoe commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

2724f39 already adds support for those. What do we need to revisit? Note that this is an interim solution anyhow.

Milan messaged me about concerns here. Speak with him.

@stevekeay
stevekeay added this pull request to the merge queue Oct 5, 2026
Merged via the queue into main with commit 2d889da Oct 5, 2026
64 checks passed
@stevekeay
stevekeay deleted the vlan_group_names branch October 5, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants