Skip to content

fix(ironic): enable Ironic’s storage-port discovery/classification - #2434

Merged
cardoe merged 1 commit into
mainfrom
enable_storage_nic
Oct 5, 2026
Merged

cardoe merged 1 commit into
mainfrom
enable_storage_nic

Conversation

@haseebsyed12

@haseebsyed12 haseebsyed12 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Ironic inspection was throwing away *-storage physnets, so storage NICs was not represented cleanly in the normal Ironic/Neutron path.

this change lets those ports keep physical_network=-storage and adds an initial TBN rule

What does this change do?

Upgrade impact

  • This change requires operator action to upgrade. If checked, add the
    upgrade-impact label and a release note: run scriv create from the
    repository root and describe the required action in the generated
    changelog.d/ file. See RELEASING.md.

Operator action means anything a deployment has to do beyond a normal resync:
deploy repo or values changes, new or removed secrets, enabling or disabling a
component, or a manual one-time step.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Python test results

497 tests   497 ✅  3s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 345fda9.

♻️ This comment has been updated with latest results.

@haseebsyed12 haseebsyed12 changed the title enable storage NICs to attach through the standard Neutron/Undersync path fix(ironic): enable storage NICs through Neutron and Undersync Oct 1, 2026
@haseebsyed12 haseebsyed12 changed the title fix(ironic): enable storage NICs through Neutron and Undersync fix(ironic): enable Ironic’s storage-port discovery/classification Oct 5, 2026
…path

The regular tenant-network path (Ironic inspection -> Neutron ML2 -> dynamic VLAN
-> Undersync) already does everything storage needs. It just refuses to carry storage ports. This change lets it.
@haseebsyed12
haseebsyed12 requested a review from a team October 5, 2026 14:56
@haseebsyed12
haseebsyed12 marked this pull request as ready for review October 5, 2026 14:56
@cardoe
cardoe added this pull request to the merge queue Oct 5, 2026
Merged via the queue into main with commit c3d87fa Oct 5, 2026
67 checks passed
@cardoe
cardoe deleted the enable_storage_nic branch October 5, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants