Repository navigation
fix(ironic): enable Ironic’s storage-port discovery/classification - #2434
Merged
Merged
Conversation
Python test results497 tests 497 ✅ 3s ⏱️ Results for commit 345fda9. ♻️ This comment has been updated with latest results. |
…path The regular tenant-network path (Ironic inspection -> Neutron ML2 -> dynamic VLAN -> Undersync) already does everything storage needs. It just refuses to carry storage ports. This change lets it.
haseebsyed12
force-pushed
the
enable_storage_nic
branch
from
October 5, 2026 12:35
6fd788b to
345fda9
Compare
haseebsyed12
marked this pull request as ready for review
October 5, 2026 14:56
abhimanyu003
approved these changes
Oct 5, 2026
cardoe
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ironic inspection was throwing away *-storage physnets, so storage NICs was not represented cleanly in the normal Ironic/Neutron path.
this change lets those ports keep physical_network=-storage and adds an initial TBN rule
What does this change do?
Upgrade impact
upgrade-impactlabel and a release note: runscriv createfrom therepository root and describe the required action in the generated
changelog.d/file. See RELEASING.md.Operator action means anything a deployment has to do beyond a normal resync:
deploy repo or values changes, new or removed secrets, enabling or disabling a
component, or a manual one-time step.