Repository navigation
no-merge: trim enroll for fast tests - #2611
Draft
haseebsyed12 wants to merge 1 commit into
Draft
haseebsyed12 wants to merge 1 commit into
haseebsyed12 wants to merge 1 commit into
Conversation
Strip BMC init/password, out-of-band and agent inspection, Dell BIOS, RAID, and firmware from the default enroll() flow. The trimmed flow runs chassis_info (read-only, for node naming) -> create_or_update -> the run_post_inspection_runbook loop -> transition(provide/available), and main() still writes --node-uuid-output on success for the post-enroll hook. All CLI args and parse_bool/parse_runbooks are preserved; old_password/firmware_update/raid_configure stay in the signature but are inert. Update tests: remove the two full-sequence tests that asserted removed paths, rewrite test_post_inspection_runbook_order and test_post_inspection_runbooks_stop_on_failure for the trimmed flow, preserve all in-scope coverage. enroll-server.yaml: doc note only; contract/params/output/args/mounts unchanged. Gates: ruff + uv build + pytest (822 passed) green; helm lint/template, kustomize renders green; deploy-repo argo-lint/unittest unchanged vs baseline.
Python test results487 tests +368 482 ✅ +363 48s ⏱️ +42s Results for commit 1f0816e. ± Comparison against base commit c603f47. This pull request removes 119 and adds 487 tests. Note that renamed tests count towards both. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip BMC init/password, out-of-band and agent inspection, Dell BIOS, RAID, and firmware from the default enroll() flow. The trimmed flow runs chassis_info (read-only, for node naming) -> create_or_update -> the run_post_inspection_runbook loop -> transition(provide/available), and main() still writes --node-uuid-output on success for the post-enroll hook. All CLI args and parse_bool/parse_runbooks are preserved; old_password/firmware_update/raid_configure stay in the signature but are inert.
What does this change do?
Upgrade impact
upgrade-impactlabel and a release note: runscriv createfrom therepository root and describe the required action in the generated
changelog.d/file. See RELEASING.md.Operator action means anything a deployment has to do beyond a normal resync:
deploy repo or values changes, new or removed secrets, enabling or disabling a
component, or a manual one-time step.