Repository navigation
feat(kubectl-us): audit and repair NAT gateway_port on routers - #2614
Merged
Merged
Conversation
github-actions
Bot
added
the
skip-changelog
Python test results497 tests 497 ✅ 2s ⏱️ Results for commit 0c4f62b. ♻️ This comment has been updated with latest results. |
cardoe
force-pushed
the
fix/kubectl-us-router-audit-nat-gateway-port
branch
from
November 2, 2026 21:56
572a053 to
93f3e46
Compare
cardoe
changed the title
northd ignores a NAT whose `gateway_port` is not a distributed gateway port on the router, logging "is not a valid distributed gateway port". For a floating IP that breaks the dnat_and_snat entry, but nothing in `router audit` noticed: the router, LRPs and LSPs all looked healthy. Load the router's NAT rows and FAIL any whose `gateway_port` is not an attached LRP with `gateway_chassis` or `ha_chassis_group`. NATs without a `gateway_port` are skipped. `router repair` gains a NAT domain that plans `clear NAT <uuid> gateway_port` for each failing NAT, applies it in the same transaction as the other repairs, and verifies the NATs are clean afterwards. The repair summary line now reports the NAT count.
cardoe
force-pushed
the
fix/kubectl-us-router-audit-nat-gateway-port
branch
from
November 2, 2026 21:57
93f3e46 to
0c4f62b
Compare
cardoe
marked this pull request as ready for review
November 2, 2026 21:58
nicholaskuechler
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
northd ignores a NAT whose
gateway_portis not a distributed gatewayport on the router, logging "is not a valid distributed gateway port".
For a floating IP that breaks the dnat_and_snat entry, but nothing in
router auditnoticed: the router, LRPs and LSPs all looked healthy.Load the router's NAT rows and FAIL any whose
gateway_portis not anattached LRP with
gateway_chassisorha_chassis_group. NATs withouta
gateway_portare skipped.router repairgains a NAT domain that plansclear NAT <uuid> gateway_portfor each failing NAT, applies it in the same transaction
as the other repairs, and verifies the NATs are clean afterwards. The
repair summary line now reports the NAT count.