Repository navigation
feat(ironic): configure SNMPv3 user through runbooks - #2618
Merged
Merged
Conversation
haseebsyed12
changed the title
Python test results63 tests 63 ✅ 7s ⏱️ Results for commit c2d16f7. ♻️ This comment has been updated with latest results. |
haseebsyed12
force-pushed
the
enable-obm-monitoring
branch
2 times, most recently
from
October 30, 2026 14:15
fe821bb to
52ab62b
Compare
haseebsyed12
marked this pull request as ready for review
October 30, 2026 15:51
haseebsyed12
force-pushed
the
enable-obm-monitoring
branch
from
October 30, 2026 15:53
9644790 to
abfbc78
Compare
… of the node's provisioning lifecycle using vendor passthru
haseebsyed12
force-pushed
the
enable-obm-monitoring
branch
4 times, most recently
from
November 2, 2026 13:21
08b86d1 to
3121abc
Compare
haseebsyed12
changed the title
haseebsyed12
force-pushed
the
enable-obm-monitoring
branch
from
November 2, 2026 14:18
3121abc to
002a1d8
Compare
…y disabling automated cleaning
haseebsyed12
force-pushed
the
enable-obm-monitoring
branch
from
November 2, 2026 15:42
002a1d8 to
c2d16f7
Compare
cardoe
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
Adds the
configure-snmpv3-user --node <name-or-uuid>command and thebmc-configure-snmpv3-userArgo WorkflowTemplate to configure monitoring on existing baremetal nodes through the Ironic runbook, without re-enrollment.The workflow selects the operation from the node's current state:
manageable: run the runbook through manual cleaning and return tomanageable.active: run the runbook through servicing and return toactive.available: save the original automated-cleaning policy, disable automated cleaning, move tomanageable, run the runbook, then return toavailableand restore the policy.The runbook must disable the ramdisk and have a matching node trait. Nodes in maintenance or unsupported provisioning states are rejected before starting the operation.
The workflow waits for busy nodes, retries HTTP 409 conflicts on individual mutations, and rechecks state before each attempt. A per-node Argo mutex serializes workflows using the same mutex. Interrupted operations retain the saved cleaning policy so a later run can restore it safely. Runbook errors are reported even when Ironic returns the node to the expected stable state.
Upgrade impact
The workflow uses the existing
bmc-configure-snmpv3-userIronic runbook andbaremetal-manageOpenStack credentials. The runbook must be present with the required traits and ramdisk disabled before invoking the workflow.