Repository navigation
Commit 6e02bb8
committed
fix(base): angle_std returned nan for identical angles
The length of the mean of the unit vectors, R, is at most 1 but rounding can
make it 1 + eps, so -2 * log(R) was a tiny negative number and its square root
nan, with 'invalid value encountered in sqrt'. For example angle_std of 100
copies of -2.9. 33 of 378 combinations of angle and sample count failed.
Clamp at zero.1 parent 3332e9c commit 6e02bb8
2 files changed
Lines changed: 16 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
698 | 698 | | |
699 | 699 | | |
700 | 700 | | |
701 | | - | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
702 | 705 | | |
703 | 706 | | |
704 | 707 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
397 | 398 | | |
398 | 399 | | |
399 | 400 | | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
400 | 412 | | |
401 | 413 | | |
402 | 414 | | |
| |||
0 commit comments