Repository navigation
Commit b638e40
authored
Reject unsupported ndarray ranks in isvector (#239)
isvector() accepts higher-rank arrays and crashes on zero-dimensional
arrays. Require two dimensions before checking row/column shapes,
matching its documented contract and preventing homogeneous conversions
from silently flattening unsupported inputs. Restore positive controls
hidden by a duplicate test name.
Thirteen regressions fail before the fix. Full suites pass on Windows
Python 3.10/3.12/3.14 and Linux Python 3.13: 351 passed, three skipped,
18 subtests passed. Changed-file pre-commit checks and package builds
pass.1 parent bc2a188 commit b638e40
2 files changed
Lines changed: 24 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
510 | 510 | | |
511 | 511 | | |
512 | 512 | | |
513 | | - | |
514 | | - | |
| 513 | + | |
| 514 | + | |
515 | 515 | | |
516 | 516 | | |
517 | 517 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
212 | 213 | | |
213 | 214 | | |
214 | 215 | | |
215 | | - | |
| 216 | + | |
216 | 217 | | |
217 | 218 | | |
218 | 219 | | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
219 | 240 | | |
220 | 241 | | |
221 | 242 | | |
| |||
0 commit comments