Repository navigation
fix(graphics): ignore sign of scalar in expand_dims, document reversed limits - #262
Merged
Merged
Conversation
…d limits A negative scalar previously produced reversed limits (-3 -> [3,-3,...]), silently inverting the axes. A scalar is symmetric about zero, so use abs(). Document that min > max in the 2/4/6 element forms is passed through and matplotlib inverts the axis. Add test_expand_dims. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
12 tasks done
taughz
approved these changes
Oct 26, 2026
taughz
pushed a commit
that referenced
this pull request
Nov 5, 2026
Fixes #261. `expand_dims()` raises `TypeError` even though `dim=None` is its documented default. Return `None` for an unspecified extent so callers can choose autoscaling or obtain limits elsewhere. Update the argument and return annotations and docstring to describe this behavior. Validate `nd` before returning, so unsupported dimensions still raise `ValueError`, including when `dim` is `None`; zero remains an explicit extent. Add regressions for omitted and explicit `None` in 2D/3D, explicit numeric extents, malformed vectors, and unsupported dimensions. Preserve the negative-scalar and reversed-limit behavior from #262 and its regression tests. Validation on this branch including upstream master `824a459` (`MPLBACKEND=Agg`): - Python 3.12.14 full suite: **476 passed, 3 skipped**, with 71 subtests passed and 23 warnings. - Graphics tests on Python 3.10.12 and 3.12.14: **21 passed**, with 8 subtests passed on each version. - Repository pre-commit hooks (Black 23.10.0, EOF, debug statements, trailing whitespace) and `git diff --check` pass. Black also wraps existing long lines in the touched graphics module and test file. The existing internal callers already guard `None`. Downstream bdsim behavior has not been tested; the `scale=None` timing change noted in #261 remains applicable. Signed-off-by: 李永祺 <doribelove@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A negative scalar passed to
expand_dims(and soplotvol2/plotvol3/Animate) gave reversed limits, e.g.-3->[3, -3, 3, -3], silently inverting the axes. A scalar is symmetric about zero, so the sign is now ignored viaabs().For the 2/4/6 element forms no min < max check is added. Matplotlib inverts an axis when given reversed limits, so this is a useful way to flip an axis, and
expand_dimsis a pure function with no axes to callinvert_xaxis()on. The docstring now says so.Adds
test_expand_dims.🤖 Generated with Claude Code