Repository navigation
fix(spline): validate interpolation time span - #289
Open
WilliamK112 wants to merge 1 commit into
Open
WilliamK112 wants to merge 1 commit into
WilliamK112 wants to merge 1 commit into
Conversation
Validate the endpoint span instead of the absolute final time so negative and offset time ranges are accepted. Report equal endpoints clearly before normalization and cover both normalized and unnormalized regressions. Signed-off-by: Ching-Wei Kang <ckang53@wisc.edu>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #287.
Validation
MPLBACKEND=Agg python -m pytest tests/test_spline.py -q— 11 passed, 2 skippedMPLBACKEND=Agg python -m pytest -q --timeout=50 --timeout_method=thread— 571 passed, 3 skipped, 99 subtests passedgit diff --checkAI assistance was used to investigate, implement, and validate this focused change.