Repository navigation
Make line-plane intersection tolerance independent of coordinate scale - #291
Open
xixihaha-ha wants to merge 1 commit into
Open
xixihaha-ha wants to merge 1 commit into
xixihaha-ha wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line3.intersect_plane()can returnNonefor perpendicular lines and planes after rescaling their homogeneous representations. For example:Scale the parallelism threshold by both direction and normal norms, so
toltests angular separation independently of their magnitudes. The intersection formula and return structure are unchanged.Regressions cover signed rescaling, near-parallel tolerance, point/parameter consistency, and parallel lines. Five new subcases fail on unchanged
25b19b3; all eleven pass with the fix. Full suite on Windows/Python 3.11.14: 568 passed, 4 skipped, 110 subtests passed. Black 23.10.0 andgit diff --checkpass.Prepared and validated with OpenAI Codex assistance.