Fixes report-impact option output

Author: raphaelstolt

CHANGELOG.md

@@ -7,6 +7,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 
 ## [Unreleased]
 
+### Fixed
+- The `--report-impact` option output is now formatted correctly.
+
 ### Changed
 - Removed the `symfony/finder` dependency.
 

README.md

@@ -207,7 +207,7 @@ Would expect the following .gitattributes file content:
  bin/release-version export-ignore
 ```
 
-The `--report-stale-export-ignores` option extends the validation to look for export-ignore statements referencing 
+The `--report-stale-export-ignores` option extends the validation to look for export-ignore statements referencing
 non-existent repository artefacts. In combination with the `--diff` option these will be shown in the output.
 
 The `--report-impact` option displays a distribution impact report that compares the project archive with and without
@@ -218,7 +218,7 @@ savings and CO₂ emission avoided based on a typical download volume.
 lean-package-validator validate --report-impact [<directory>]
 
 Distribution impact
-────────────────────────────────
+───────────────────────────────────────────
 Original archive:               1.25 MB
 Optimized archive:              0.45 MB
 Size reduction:                 64.0%

src/ImpactReport.php

@@ -294,6 +294,23 @@ public static function formatCo2(float $grams): string
         return \number_format($grams, 2) . ' g CO₂';
     }
 
+    /**
+     * Pad a string to a specified display width (handles multi-byte characters).
+     *
+     * @param string $string
+     * @param int $width
+     * @return string
+     */
+    private static function strPadDisplayWidth(string $string, int $width): string
+    {
+        $currentWidth = \mb_strwidth($string);
+        if ($currentWidth >= $width) {
+            return $string;
+        }
+
+        return $string . \str_repeat(' ', $width - $currentWidth);
+    }
+
     /**
      * Generate the formatted impact report string.
      *
@@ -308,17 +325,19 @@ public function generateReport(): string
         $estimatedDataSaved = self::formatBytesToGb($this->getEstimatedDataSavedBytes());
         $co2Avoided = self::formatCo2($this->getEstimatedCo2Avoided());
 
-        // Label column width for alignment
+        // Label column display width for alignment
         $labelWidth = 32;
+        // Separator width
+        $separatorWidth = 43;
 
         $report = "Distribution impact" . PHP_EOL;
-        $report .= \str_repeat('─', $labelWidth) . PHP_EOL;
-        $report .= \str_pad('Original archive:', $labelWidth) . ' ' . $originalSize . PHP_EOL;
-        $report .= \str_pad('Optimized archive:', $labelWidth) . ' ' . $optimizedSize . PHP_EOL;
-        $report .= \str_pad('Size reduction:', $labelWidth) . ' ' . $reduction . PHP_EOL;
-        $report .= \str_pad('Data saved/download:', $labelWidth) . ' ' . $dataSaved . PHP_EOL;
-        $report .= \str_pad('Estimated data saved:', $labelWidth) . ' ' . $estimatedDataSaved . PHP_EOL;
-        $report .= \str_pad('Estimated CO₂ emission avoided:', $labelWidth) . ' ' . $co2Avoided . PHP_EOL;
+        $report .= \str_repeat('─', $separatorWidth) . PHP_EOL;
+        $report .= self::strPadDisplayWidth('Original archive:', $labelWidth) . $originalSize . PHP_EOL;
+        $report .= self::strPadDisplayWidth('Optimized archive:', $labelWidth) . $optimizedSize . PHP_EOL;
+        $report .= self::strPadDisplayWidth('Size reduction:', $labelWidth) . $reduction . PHP_EOL;
+        $report .= self::strPadDisplayWidth('Data saved/download:', $labelWidth) . $dataSaved . PHP_EOL;
+        $report .= self::strPadDisplayWidth('Estimated data saved:', $labelWidth) . $estimatedDataSaved . PHP_EOL;
+        $report .= self::strPadDisplayWidth('Estimated CO₂ emission avoided:', $labelWidth) . $co2Avoided . PHP_EOL;
 
         return $report;
     }