fix: fail init when package manager is unavailable - #2849
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
init --pm <name>currently logs an error and returns normally when the requested package manager is unavailable. That makes the CLI report a successful exit status even though no project was created.Throw a
CLIErrorinstead so the existing command error handler reports the failure and exits nonzero. This changes only the unavailable explicit-package-manager path.Test Plan
main: the initialization promise resolves toundefinedinstead of rejecting.yarn test --selectProjects unit --runInBand: 57 suites passed, 315 tests passed, 1 todo, 62 snapshots passed.yarn lint: passed with the two pre-existing warnings inopenURLMiddleware.test.tsandcommands/init/version.ts.yarn build: passed for all packages.git diff --check: passed.init TestProject --install-podsprocess waited indefinitely. No broad end-to-end result is claimed.Checklist
react-nativecheckout (instructions).