Repository navigation
Setup Hermes V1 testing - #45
j-piasecki wants to merge 4 commits into
Conversation
9764245 to
d89a744
Compare
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for working on this. I left a couple of questions
| "typescript": "^5.8.3" | ||
| }, | ||
| + "resolutions": { | ||
| + "hermes-compiler": "250829098.0.2" |
There was a problem hiding this comment.
latest-v1 is now 250829098.0.3
Do you know if there is a way to use a specific tag instead of a version?
Otherwise, we would have to bump this every time we release a new version of Hermes.
There was a problem hiding this comment.
It's possible to use a tag instead of a specific version in package.json, but it needs to use the same version for the Android config.
I've added a script that will update the patch with the latest version before applying it. Is that ok?
| jobs: | ||
| test-hermes-v1-android: | ||
| name: Test Hermes V1 on Android | ||
| runs-on: 4-core-ubuntu |
There was a problem hiding this comment.
Why this? I believe you won't be able to run this as we're on the free tier
There was a problem hiding this comment.
We need large machine for the E2E tests to run reliably.
There was a problem hiding this comment.
I don't think this job will be able to run on this org as billing is not enabled
Q: Why is this workflow added in this repo and not inside |
|
Turns out, large machines are not available in public repos. We have to move this back to the React native repository, although we lose the Discord notification capabilities. 😢 |
|
Closing in favor of react/react-native#54576 |
Summary
Sets up automated testing of Hermes V1. The workflow will set up a new RN app from the template, enable Hermes V1, build the app, and run a simple E2E test using it.
E2E is based on the setup used in the React Native repository:
maestro-ios.jsmaestro-android.jsstart.ymlIf I understand the repository setup correctly, to pick up the results of the actions and show them on the website, the action needs to upload GitHub artifacts in a specific format, which I believe the new workflow does. Please correct me if I'm wrong.