Skip to content

Commit 6e23d68

Browse files
AlexeySoshinmeta-codesync[bot]
authored andcommitted
Use explicit shadow extraction types (#59192)
Summary: Pull Request resolved: #59192 Replace redundant casts around Robolectric shadow extraction with explicit generic type arguments. This preserves compatibility with older Kotlin type inference while compiling cleanly under Kotlin 2.3. Changelog: [Internal] Reviewed By: siaojiecai Differential Revision: D125947056 fbshipit-source-id: 55124f63a9d2a7d3d86989e1e80025d1448de1a2
1 parent 213148b commit 6e23d68

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎packages/react-native/ReactAndroid/src/test/java/com/facebook/testutils/shadows/ShadowArguments.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class ShadowArguments {
2929
@Implementation
3030
fun fromJavaArgs(args: Array<Any?>): WritableNativeArray =
3131
WritableNativeArray().apply {
32-
(Shadow.extract(this) as ShadowNativeArray).backingArray = JavaOnlyArray.of(*args)
32+
Shadow.extract<ShadowNativeArray>(this).backingArray = JavaOnlyArray.of(*args)
3333
}
3434
}
3535
}

‎packages/react-native/ReactAndroid/src/test/java/com/facebook/testutils/shadows/ShadowArrayBuffer.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ open class ShadowArrayBuffer {
3434
/** Simulates the native peer revoking a borrow when the call frame that lent the bytes ends. */
3535
@JvmStatic
3636
fun invalidate(arrayBuffer: ArrayBuffer) {
37-
(Shadow.extract(arrayBuffer) as ShadowArrayBuffer).bytesValid = false
37+
Shadow.extract<ShadowArrayBuffer>(arrayBuffer).bytesValid = false
3838
}
3939
}
4040
}

‎packages/react-native/ReactAndroid/src/test/java/com/facebook/testutils/shadows/ShadowNativeArray.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,6 @@ open class ShadowNativeArray {
1919

2020
companion object {
2121
fun getContents(array: NativeArray): List<Any?> =
22-
(Shadow.extract(array) as ShadowNativeArray).backingArray.toArrayList()
22+
Shadow.extract<ShadowNativeArray>(array).backingArray.toArrayList()
2323
}
2424
}

‎packages/react-native/ReactAndroid/src/test/java/com/facebook/testutils/shadows/ShadowNativeMap.kt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,6 @@ open class ShadowNativeMap {
4141

4242
companion object {
4343
fun getContents(map: NativeMap): Map<String, Any?> =
44-
(Shadow.extract(map) as ShadowNativeMap).backingMap.toHashMap()
44+
Shadow.extract<ShadowNativeMap>(map).backingMap.toHashMap()
4545
}
4646
}

0 commit comments

Comments
 (0)