Simplify createTestReactApplicationContext calls (#59508)

Summary:
Pull Request resolved: #59508

Use the default `application` argument of `createTestReactApplicationContext`
at every call site instead of passing `RuntimeEnvironment.getApplication()`
explicitly, and expose the helper as `JvmStatic` so the remaining Java test
no longer needs `INSTANCE`. Migrating that test to Kotlin is blocked by
inherited JVM signature clashes when subclassing `BaseViewManagerDelegate`
from Kotlin.

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D127584468

fbshipit-source-id: aad8d61bf0553945c217e5db8fb9eda6128440c3

Author: christophpurrer

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/RootViewTest.kt

@@ -38,7 +38,6 @@ import org.mockito.kotlin.verify
 import org.mockito.kotlin.whenever
 import org.robolectric.Robolectric
 import org.robolectric.RobolectricTestRunner
-import org.robolectric.RuntimeEnvironment
 import org.robolectric.annotation.Config
 
 @Config(shadows = [ShadowArguments::class, ShadowSoLoader::class])
@@ -51,7 +50,7 @@ class RootViewTest {
   fun setUp() {
     ReactNativeFeatureFlagsForTests.setUp()
 
-    reactContext = spy(createTestReactApplicationContext(RuntimeEnvironment.getApplication()))
+    reactContext = spy(createTestReactApplicationContext())
     doNothing().whenever(reactContext).emitDeviceEvent(any(), any())
 
     DisplayMetricsHolder.initDisplayMetricsIfNotInitialized(reactContext)

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/bridge/ReactTestHelper.kt

@@ -21,6 +21,7 @@ object ReactTestHelper {
 
   @OptIn(UnstableReactNativeAPI::class)
   @JvmOverloads
+  @JvmStatic
   fun createTestReactApplicationContext(
       application: Application = RuntimeEnvironment.getApplication()
   ): ReactApplicationContext {

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/fabric/FabricUIManagerPullModelTest.kt

@@ -39,7 +39,6 @@ import org.junit.Test
 import org.junit.runner.RunWith
 import org.mockito.kotlin.mock
 import org.robolectric.RobolectricTestRunner
-import org.robolectric.RuntimeEnvironment
 import org.robolectric.Shadows.shadowOf
 import org.robolectric.annotation.Config
 import org.robolectric.shadow.api.Shadow
@@ -77,8 +76,7 @@ class FabricUIManagerPullModelTest {
   fun setup() {
     ReactNativeFeatureFlagsForTests.setUp()
     overrideFeatureFlags()
-    reactContext =
-        ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
+    reactContext = ReactTestHelper.createTestReactApplicationContext()
     underTest =
         FabricUIManager(
             reactContext,

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/fabric/MountingManagerAnimatedPropsTest.kt

@@ -31,7 +31,6 @@ import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.robolectric.RobolectricTestRunner
-import org.robolectric.RuntimeEnvironment
 import org.robolectric.annotation.Config
 
 @RunWith(RobolectricTestRunner::class)
@@ -55,8 +54,7 @@ class MountingManagerAnimatedPropsTest {
   @Before
   fun setUp() {
     ReactNativeFeatureFlagsForTests.setUp()
-    val reactContext =
-        ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
+    val reactContext = ReactTestHelper.createTestReactApplicationContext()
     themedReactContext = ThemedReactContext(reactContext, reactContext, null, -1)
     mountingManager =
         MountingManager(ViewManagerRegistry(listOf<ViewManager<*, *>>(ReactViewManager())), {})

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/fabric/MountingManagerTest.kt

@@ -22,7 +22,6 @@ import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.robolectric.RobolectricTestRunner
-import org.robolectric.RuntimeEnvironment
 import org.robolectric.annotation.Config
 
 /** Tests [FabricUIManager] */
@@ -37,7 +36,7 @@ class MountingManagerTest {
   @Before
   fun setUp() {
     ReactNativeFeatureFlagsForTests.setUp()
-    val reactContext = createTestReactApplicationContext(RuntimeEnvironment.getApplication())
+    val reactContext = createTestReactApplicationContext()
     themedReactContext = ThemedReactContext(reactContext, reactContext, null, -1)
     val viewManagers = listOf<ViewManager<*, *>>(ReactViewManager())
     mountItemExecutor = MountItemExecutor {

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/fabric/SurfaceMountingManagerEventOrderingTest.kt

@@ -34,7 +34,6 @@ import org.mockito.kotlin.any
 import org.mockito.kotlin.mock
 import org.mockito.kotlin.never
 import org.robolectric.RobolectricTestRunner
-import org.robolectric.RuntimeEnvironment
 import org.robolectric.annotation.Config
 import org.robolectric.annotation.LooperMode
 
@@ -60,8 +59,7 @@ class SurfaceMountingManagerEventOrderingTest {
   @Before
   fun setUp() {
     ReactNativeFeatureFlagsForTests.setUp()
-    val reactContext =
-        ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
+    val reactContext = ReactTestHelper.createTestReactApplicationContext()
     themedReactContext = ThemedReactContext(reactContext, reactContext, null, -1)
     mountingManager =
         MountingManager(

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/fabric/SurfaceMountingManagerSynchronousMountPropsTest.kt

@@ -34,7 +34,6 @@ import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.robolectric.RobolectricTestRunner
-import org.robolectric.RuntimeEnvironment
 import org.robolectric.annotation.Config
 
 /**
@@ -66,8 +65,7 @@ class SurfaceMountingManagerSynchronousMountPropsTest {
   @Before
   fun setUp() {
     ReactNativeFeatureFlagsForTests.setUp()
-    val reactContext =
-        ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
+    val reactContext = ReactTestHelper.createTestReactApplicationContext()
     themedReactContext = ThemedReactContext(reactContext, reactContext, null, -1)
     mountingManager =
         MountingManager(

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/fabric/SurfaceMountingManagerTest.kt

@@ -26,7 +26,6 @@ import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.robolectric.RobolectricTestRunner
-import org.robolectric.RuntimeEnvironment
 import org.robolectric.annotation.Config
 
 /**
@@ -54,8 +53,7 @@ class SurfaceMountingManagerTest {
   @Before
   fun setUp() {
     ReactNativeFeatureFlagsForTests.setUp()
-    val reactContext =
-        ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
+    val reactContext = ReactTestHelper.createTestReactApplicationContext()
     themedReactContext = ThemedReactContext(reactContext, reactContext, null, -1)
     mountingManager =
         MountingManager(

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/fabric/events/TouchEventDispatchTest.kt

@@ -40,7 +40,6 @@ import org.mockito.kotlin.times
 import org.mockito.kotlin.verify
 import org.mockito.kotlin.whenever
 import org.robolectric.RobolectricTestRunner
-import org.robolectric.RuntimeEnvironment
 import org.robolectric.annotation.Config
 
 @RunWith(RobolectricTestRunner::class)
@@ -520,8 +519,7 @@ class TouchEventDispatchTest {
     metrics.density = 1f
     DisplayMetricsHolder.setScreenDisplayMetrics(metrics)
 
-    val reactContext =
-        ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
+    val reactContext = ReactTestHelper.createTestReactApplicationContext()
     val uiQueueThread: MessageQueueThread = mock()
     whenever(uiQueueThread.isOnThread()).thenReturn(true)
     val queueConfig: ReactQueueConfiguration = mock()

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/interfaces/ExtraWindowEventListenerTest.kt

@@ -20,7 +20,6 @@ import org.mockito.kotlin.never
 import org.mockito.kotlin.times
 import org.mockito.kotlin.verify
 import org.robolectric.RobolectricTestRunner
-import org.robolectric.RuntimeEnvironment
 import org.robolectric.annotation.Config
 
 @RunWith(RobolectricTestRunner::class)
@@ -32,8 +31,7 @@ class ExtraWindowEventListenerTest {
   @Before
   fun setUp() {
     ReactNativeFeatureFlagsForTests.setUp()
-    reactContext =
-        ReactTestHelper.createTestReactApplicationContext(RuntimeEnvironment.getApplication())
+    reactContext = ReactTestHelper.createTestReactApplicationContext()
     window = mock()
   }