Repository navigation
Commit b67b7ba
fix(podspec): remove duplicate scrollview subspec in React-FabricComponents (#57452)
Summary:
Upstream version of our react-native-macos fix (microsoft#2969).
The `scrollview` subspec is declared in both `React-Fabric.podspec` (recursive
`scrollview/**/*` glob) and `React-FabricComponents.podspec` (`scrollview/*` +
`platform/cxx` + `platform/ios`). The globs overlap, so after `pod install` the
same sources (`ScrollViewShadowNode.cpp`, `BaseScrollViewProps.cpp`,
`ScrollEvent.cpp`, etc.) land in both the `React-Fabric` and
`React-FabricComponents` Pods targets, and consumers that link both (e.g. via
`-all_load`) hit duplicate symbol errors.
`React-Fabric.podspec`'s recursive glob already covers everything
FabricComponents listed, so this removes the duplicate subspec.
Note on SPM: the SPM manifest (`Package.swift`) handles scrollview differently —
it's assigned solely to the `React-Fabric` target, with no FabricComponents
scrollview target. This is an existing divergence between the CocoaPods and SPM
setups; this PR only touches CocoaPods, so SPM is unaffected.
## Changelog:
[Internal] -
Pull Request resolved: #57452
Test Plan: CI should pass.
Reviewed By: christophpurrer
Differential Revision: D110914625
Pulled By: cipolleschi
fbshipit-source-id: 2617470ef71ba2e827646d087ab876ee008b88c31 parent 904f0ae commit b67b7ba
1 file changed
Lines changed: 0 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | 104 | | |
116 | 105 | | |
117 | 106 | | |
| |||
0 commit comments