Fix StatusBar style and visibility on iOS 27 (#58926)

Summary:
Fixes #58758.
In apps built with the iOS 27 SDK, `StatusBar.setBarStyle` and `StatusBar.setHidden` do nothing. `RCTStatusBarManager` uses the `UIApplication` status bar setters, and UIKit turns them into no-ops for apps linked against the iOS 27 SDK. Apps built with the iOS 26 SDK are not affected. A plain UIKit app built with the iOS 27 SDK shows that with `UIViewControllerBasedStatusBarAppearance` set to `NO`, nothing can change the status bar on iOS 27. With `YES`, the view controller methods still work.

This change moves `StatusBar` to the view controller model. The module stores the requested style, hidden state, and animation in a new `RCTStatusBarAppearance` class and calls `setNeedsStatusBarAppearanceUpdate` on the presented view controller. The default root view controller from `RCTDefaultReactNativeFactoryDelegate` and the Fabric modal controller return those values. The modal keeps the status bar that was on screen when it opened until JS changes it, so a status bar set natively (ie by react-native-screens) is not lost. With `NO`, the module still calls the `UIApplication` setters, so apps built with older SDKs keep working. When React Native is built with the iOS 27 SDK and runs on iOS 27, it also logs one warning that tells the developer to set the key to `YES`.

Apps that override `createRootViewController` need their view controller to return the `RCTStatusBarAppearance` values for `StatusBar` to work on iOS 27.

A similar change, #25919, landed in March 2020 and was reverted the next day

## Changelog:

[IOS] [FIXED] - `StatusBar` style and visibility work on iOS 27 for apps built with the iOS 27 SDK when `UIViewControllerBasedStatusBarAppearance` is `YES`. Custom root view controllers must return the `RCTStatusBarAppearance` values.

Pull Request resolved: #58926

Test Plan:
12 new XCTest cases in `RCTStatusBarAppearanceTests`. The OSS XCTest file has no internal BUCK owner and was not run locally.

Validation for the review update:
- Applied the explicit legacy-API guard to both `setStyle:animated:` and `setHidden:withAnimation:`. The appearance-state update remains unconditional; UIKit setters and warnings remain limited to apps using app-level status bar appearance.
- Meta-managed `clang-format` and `arc lint` passed for `RCTStatusBarManager.mm`.
- Built `ReactApple`, `CoreModulesApple`, `RCTFabricApple` and `RCTAppDelegateApple` for `iphonesimulator-arm64` with annotation checks enabled.
- No public headers changed, so API snapshots are unchanged.
- Diff-time CI will rerun for the updated code.

Reviewed By: javache

Differential Revision: D127555263

Pulled By: cipolleschi

fbshipit-source-id: 9a6d21236987e309917e620387b34e88e7da24c7

Author: alanjhughes

packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm

@@ -14,9 +14,32 @@
 #endif
 
 #import <RCTAnimatedModuleProvider/RCTAnimatedModuleProvider.h>
+#import <React/RCTStatusBarAppearance.h>
 #import <react/featureflags/ReactNativeFeatureFlags.h>
 #import <react/nativemodule/defaults/DefaultTurboModules.h>
 
+@interface RCTRootViewController : UIViewController
+@end
+
+@implementation RCTRootViewController
+
+- (UIStatusBarStyle)preferredStatusBarStyle
+{
+  return RCTStatusBarAppearance.style;
+}
+
+- (BOOL)prefersStatusBarHidden
+{
+  return RCTStatusBarAppearance.hidden;
+}
+
+- (UIStatusBarAnimation)preferredStatusBarUpdateAnimation
+{
+  return RCTStatusBarAppearance.updateAnimation;
+}
+
+@end
+
 @implementation RCTDefaultReactNativeFactoryDelegate {
   // C++ Native Animated provider, created once on first use (getTurboModule: may be called
   // concurrently for different module names).
@@ -35,7 +58,7 @@ - (NSURL *_Nullable)sourceURLForBridge:(nonnull RCTBridge *)bridge
 
 - (UIViewController *)createRootViewController
 {
-  return [UIViewController new];
+  return [RCTRootViewController new];
 }
 
 - (void)setRootView:(UIView *)rootView toRootViewController:(UIViewController *)rootViewController

packages/react-native/Libraries/AppDelegate/RCTUIConfiguratorProtocol.h

@@ -41,7 +41,7 @@ NS_ASSUME_NONNULL_BEGIN
 
 /**
  * It creates the RootViewController.
- * By default, it creates a new instance of a `UIViewController`.
+ * By default, it creates a view controller that returns the `RCTStatusBarAppearance` values.
  * You can override it to provide your own initial ViewController.
  *
  * @return: an instance of `UIViewController`.

packages/react-native/React/Base/RCTStatusBarAppearance.h

@@ -0,0 +1,26 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#import <UIKit/UIKit.h>
+
+NS_ASSUME_NONNULL_BEGIN
+
+/**
+ * The status bar state set from JavaScript. Root view controllers return these values from their status bar methods.
+ */
+@interface RCTStatusBarAppearance : NSObject
+
+@property (class, nonatomic, readonly) UIStatusBarStyle style;
+@property (class, nonatomic, readonly) BOOL hidden;
+@property (class, nonatomic, readonly) UIStatusBarAnimation updateAnimation;
+
++ (void)setStyle:(UIStatusBarStyle)style animated:(BOOL)animated;
++ (void)setHidden:(BOOL)hidden withAnimation:(UIStatusBarAnimation)animation;
+
+@end
+
+NS_ASSUME_NONNULL_END

packages/react-native/React/Base/RCTStatusBarAppearance.mm

@@ -0,0 +1,62 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#import "RCTStatusBarAppearance.h"
+
+#import "RCTAssert.h"
+#import "RCTUtils.h"
+
+static UIStatusBarStyle sStyle = UIStatusBarStyleDefault;
+static BOOL sHidden = NO;
+static UIStatusBarAnimation sUpdateAnimation = UIStatusBarAnimationNone;
+
+@implementation RCTStatusBarAppearance
+
++ (UIStatusBarStyle)style
+{
+  return sStyle;
+}
+
++ (BOOL)hidden
+{
+  return sHidden;
+}
+
++ (UIStatusBarAnimation)updateAnimation
+{
+  return sUpdateAnimation;
+}
+
++ (void)setStyle:(UIStatusBarStyle)style animated:(BOOL)animated
+{
+  RCTAssertMainQueue();
+  sStyle = style;
+  [self updateStatusBarAnimated:animated];
+}
+
++ (void)setHidden:(BOOL)hidden withAnimation:(UIStatusBarAnimation)animation
+{
+  RCTAssertMainQueue();
+  sHidden = hidden;
+  sUpdateAnimation = animation;
+  [self updateStatusBarAnimated:animation != UIStatusBarAnimationNone];
+}
+
++ (void)updateStatusBarAnimated:(BOOL)animated
+{
+  UIViewController *viewController = RCTPresentedViewController();
+  if (animated) {
+    [UIView animateWithDuration:UINavigationControllerHideShowBarDuration
+                     animations:^{
+                       [viewController setNeedsStatusBarAppearanceUpdate];
+                     }];
+  } else {
+    [viewController setNeedsStatusBarAppearanceUpdate];
+  }
+}
+
+@end

packages/react-native/React/CoreModules/RCTStatusBarManager.mm

@@ -11,6 +11,7 @@
 #import <React/RCTEventDispatcherProtocol.h>
 #import <React/RCTInitializing.h>
 #import <React/RCTLog.h>
+#import <React/RCTStatusBarAppearance.h>
 #import <React/RCTUtils.h>
 
 #import <FBReactNativeSpec/FBReactNativeSpec.h>
@@ -68,6 +69,28 @@ static BOOL RCTViewControllerBasedStatusBarAppearance()
   return value;
 }
 
+// UIKit makes the app-level setters no-ops only for apps built with the iOS 27 SDK.
+static BOOL RCTAppLevelStatusBarIsNoOp()
+{
+#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 270000
+  if (@available(iOS 27.0, *)) {
+    return YES;
+  }
+#endif
+  return NO;
+}
+
+static void RCTWarnAppLevelStatusBarUnavailable()
+{
+  static dispatch_once_t onceToken;
+  dispatch_once(&onceToken, ^{
+    RCTLogWarn(
+        @"StatusBar has no effect because UIViewControllerBasedStatusBarAppearance is NO in Info.plist. "
+        @"Apps built with the iOS 27 SDK cannot use the app-level status bar API that this setting uses. "
+        @"Set UIViewControllerBasedStatusBarAppearance to YES to control the status bar from JavaScript.");
+  });
+}
+
 RCT_EXPORT_MODULE()
 
 + (BOOL)requiresMainQueueSetup
@@ -147,30 +170,32 @@ - (void)setStyle:(NSString *)style animated:(BOOL)animated
 {
   dispatch_async(dispatch_get_main_queue(), ^{
     UIStatusBarStyle statusBarStyle = [RCTConvert UIStatusBarStyle:style];
-    if (RCTViewControllerBasedStatusBarAppearance()) {
-      RCTLogWarn(@"RCTStatusBarManager is a no-op when \
-                UIViewControllerBasedStatusBarAppearance is YES; set the status bar from your view controller instead");
-    } else {
+    [RCTStatusBarAppearance setStyle:statusBarStyle animated:animated];
+    if (!RCTViewControllerBasedStatusBarAppearance()) {
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wdeprecated-declarations"
       [RCTSharedApplication() setStatusBarStyle:statusBarStyle animated:animated];
-    }
 #pragma clang diagnostic pop
+      if (RCTAppLevelStatusBarIsNoOp()) {
+        RCTWarnAppLevelStatusBarUnavailable();
+      }
+    }
   });
 }
 
 - (void)setHidden:(BOOL)hidden withAnimation:(NSString *)withAnimation
 {
   dispatch_async(dispatch_get_main_queue(), ^{
     UIStatusBarAnimation animation = [RCTConvert UIStatusBarAnimation:withAnimation];
-    if (RCTViewControllerBasedStatusBarAppearance()) {
-      RCTLogWarn(@"RCTStatusBarManager is a no-op when \
-                UIViewControllerBasedStatusBarAppearance is YES; set the status bar from your view controller instead");
-    } else {
+    [RCTStatusBarAppearance setHidden:hidden withAnimation:animation];
+    if (!RCTViewControllerBasedStatusBarAppearance()) {
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wdeprecated-declarations"
       [RCTSharedApplication() setStatusBarHidden:hidden withAnimation:animation];
 #pragma clang diagnostic pop
+      if (RCTAppLevelStatusBarIsNoOp()) {
+        RCTWarnAppLevelStatusBarUnavailable();
+      }
     }
   });
 }

packages/react-native/React/Fabric/Mounting/ComponentViews/Modal/RCTFabricModalHostViewController.mm

@@ -8,13 +8,19 @@
 #import "RCTFabricModalHostViewController.h"
 
 #import <React/RCTLog.h>
+#import <React/RCTStatusBarAppearance.h>
 #import <React/RCTSurfaceTouchHandler.h>
 
 @implementation RCTFabricModalHostViewController {
   CGRect _lastViewBounds;
 #if !TARGET_OS_TV
   RCTSurfaceTouchHandler *_touchHandler;
 #endif
+  BOOL _hasCapturedStatusBar;
+  UIStatusBarStyle _capturedStatusBarStyle;
+  BOOL _capturedStatusBarHidden;
+  UIStatusBarStyle _jsStatusBarStyleAtCapture;
+  BOOL _jsStatusBarHiddenAtCapture;
 }
 
 - (instancetype)init
@@ -46,15 +52,37 @@ - (void)loadView
 #endif
 }
 
+- (void)captureStatusBarAppearance
+{
+  UIStatusBarManager *statusBarManager = RCTUIStatusBarManager();
+  _hasCapturedStatusBar = YES;
+  _capturedStatusBarStyle = statusBarManager.statusBarStyle;
+  _capturedStatusBarHidden = statusBarManager.isStatusBarHidden;
+  _jsStatusBarStyleAtCapture = RCTStatusBarAppearance.style;
+  _jsStatusBarHiddenAtCapture = RCTStatusBarAppearance.hidden;
+}
+
 #if !TARGET_OS_TV
+// Keep the status bar from before the modal until JS changes it.
 - (UIStatusBarStyle)preferredStatusBarStyle
 {
-  return [RCTUIStatusBarManager() statusBarStyle];
+  if (_hasCapturedStatusBar && RCTStatusBarAppearance.style == _jsStatusBarStyleAtCapture) {
+    return _capturedStatusBarStyle;
+  }
+  return RCTStatusBarAppearance.style;
 }
 
 - (BOOL)prefersStatusBarHidden
 {
-  return [RCTUIStatusBarManager() isStatusBarHidden];
+  if (_hasCapturedStatusBar && RCTStatusBarAppearance.hidden == _jsStatusBarHiddenAtCapture) {
+    return _capturedStatusBarHidden;
+  }
+  return RCTStatusBarAppearance.hidden;
+}
+
+- (UIStatusBarAnimation)preferredStatusBarUpdateAnimation
+{
+  return RCTStatusBarAppearance.updateAnimation;
 }
 #endif
 

packages/react-native/React/Fabric/Mounting/ComponentViews/Modal/RCTModalHostViewComponentView.mm

@@ -17,6 +17,10 @@
 
 #import "RCTFabricModalHostViewController.h"
 
+@interface RCTFabricModalHostViewController ()
+- (void)captureStatusBarAppearance;
+@end
+
 using namespace facebook::react;
 
 #if !TARGET_OS_TV
@@ -173,6 +177,7 @@ - (void)ensurePresentedOnlyIfNeeded
     [self saveAccessibilityFocusedView];
     self.viewController.presentationController.delegate = self;
     self.viewController.modalInPresentation = _modalInPresentation;
+    [self.viewController captureStatusBarAppearance];
 
     _isPresented = YES;
     [self presentViewController:self.viewController

packages/rn-tester/RNTester/Info.plist

@@ -81,6 +81,6 @@
 		<string>UIInterfaceOrientationPortraitUpsideDown</string>
 	</array>
 	<key>UIViewControllerBasedStatusBarAppearance</key>
-	<false/>
+	<true/>
 </dict>
 </plist>

packages/rn-tester/RNTesterPods.xcodeproj/project.pbxproj

@@ -17,6 +17,7 @@
 		5C60EB1C226440DB0018C04F /* AppDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = 5C60EB1B226440DB0018C04F /* AppDelegate.mm */; };
 		602160B9478DAFF2BAB56595 /* RCTUtilsTests.m in Sources */ = {isa = PBXBuildFile; fileRef = D5D13FB1445C5C19639921CC /* RCTUtilsTests.m */; };
 		79B29C2E2E607A99007612A5 /* SceneDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = 79B29C2D2E607A99007612A5 /* SceneDelegate.mm */; };
+		7F806D4D4D97AD6403558B35 /* RCTStatusBarAppearanceTests.mm in Sources */ = {isa = PBXBuildFile; fileRef = 67B0814814F7C07E196BC295 /* RCTStatusBarAppearanceTests.mm */; };
 		8145AE06241172D900A3F8DA /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 8145AE05241172D900A3F8DA /* LaunchScreen.storyboard */; };
 		832F45BB2A8A6E1F0097B4E6 /* SwiftTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 832F45BA2A8A6E1F0097B4E6 /* SwiftTest.swift */; };
 		A975CA6C2C05EADF0043F72A /* RCTNetworkTaskTests.m in Sources */ = {isa = PBXBuildFile; fileRef = A975CA6B2C05EADE0043F72A /* RCTNetworkTaskTests.m */; };
@@ -94,6 +95,7 @@
 		4C706D402EE4AF9BE838CBA9 /* libPods-RNTester.a */ = {isa = PBXFileReference; explicitFileType = archive.ar; includeInIndex = 0; path = "libPods-RNTester.a"; sourceTree = BUILT_PRODUCTS_DIR; };
 		51BC9297B6C3163C14532020 /* Pods-RNTester.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-RNTester.release.xcconfig"; path = "Target Support Files/Pods-RNTester/Pods-RNTester.release.xcconfig"; sourceTree = "<group>"; };
 		5C60EB1B226440DB0018C04F /* AppDelegate.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = AppDelegate.mm; path = RNTester/AppDelegate.mm; sourceTree = "<group>"; };
+		67B0814814F7C07E196BC295 /* RCTStatusBarAppearanceTests.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = RCTStatusBarAppearanceTests.mm; sourceTree = "<group>"; };
 		79B29C2C2E607A99007612A5 /* SceneDelegate.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = SceneDelegate.h; path = RNTester/SceneDelegate.h; sourceTree = "<group>"; };
 		79B29C2D2E607A99007612A5 /* SceneDelegate.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; name = SceneDelegate.mm; path = RNTester/SceneDelegate.mm; sourceTree = "<group>"; };
 		8145AE05241172D900A3F8DA /* LaunchScreen.storyboard */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.storyboard; name = LaunchScreen.storyboard; path = RNTester/LaunchScreen.storyboard; sourceTree = "<group>"; };
@@ -350,6 +352,7 @@
 				E7DB20D022B2BAA5005AC45F /* RCTURLUtilsTests.m */,
 				D5D13FB1445C5C19639921CC /* RCTUtilsTests.m */,
 				E7DB20B322B2BAA4005AC45F /* RNTesterUnitTestsBundle.js */,
+				67B0814814F7C07E196BC295 /* RCTStatusBarAppearanceTests.mm */,
 			);
 			path = RNTesterUnitTests;
 			sourceTree = "<group>";
@@ -778,6 +781,7 @@
 				E7DB20E922B2BAA6005AC45F /* RCTComponentPropsTests.m in Sources */,
 				E7DB20D822B2BAA6005AC45F /* RCTJSONTests.m in Sources */,
 				602160B9478DAFF2BAB56595 /* RCTUtilsTests.m in Sources */,
+				7F806D4D4D97AD6403558B35 /* RCTStatusBarAppearanceTests.mm in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};