Repository navigation
Commit c99c491
Reach public modules through umbrellas in RN-Tester and popup-menu-android C++ (#59222)
Summary:
Pull Request resolved: #59222
Two C++ files built into RN-Tester include public React Native headers directly instead of through their module umbrella, which is an `#error` under `RN_STRICT_API`:
- `rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.cpp`,
- `react/debug/react_native_assert.h`,
- The checked-in codegen output of `react-native/popup-menu-android` (`Props.cpp`) included `react/renderer/core/PropsParserContext.h` and `propsConversions.h`.
No behavior change; this prepares RN-Tester to build with `RN_STRICT_API` by default.
Changelog: [Internal]
___
landed-with-radar-review
Differential Revision: D126328619
fbshipit-source-id: fcc301252afe87e108a78ccc5565ddc6b7bfd2941 parent 6a2c7c2 commit c99c491
2 files changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
| 12 | + | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
| 9 | + | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
0 commit comments