Skip to content

Commit c99c491

Browse files
coadometa-codesync[bot]
authored andcommitted
Reach public modules through umbrellas in RN-Tester and popup-menu-android C++ (#59222)
Summary: Pull Request resolved: #59222 Two C++ files built into RN-Tester include public React Native headers directly instead of through their module umbrella, which is an `#error` under `RN_STRICT_API`: - `rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.cpp`, - `react/debug/react_native_assert.h`, - The checked-in codegen output of `react-native/popup-menu-android` (`Props.cpp`) included `react/renderer/core/PropsParserContext.h` and `propsConversions.h`. No behavior change; this prepares RN-Tester to build with `RN_STRICT_API` by default. Changelog: [Internal] ___ landed-with-radar-review Differential Revision: D126328619 fbshipit-source-id: fcc301252afe87e108a78ccc5565ddc6b7bfd294
1 parent 6a2c7c2 commit c99c491

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

  • packages

‎packages/react-native-popup-menu-android/android/src/main/jni/react/renderer/components/ReactPopupMenuAndroidSpecs/Props.cpp‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
*/
1010

1111
#include "Props.h"
12-
#include <react/renderer/core/PropsParserContext.h>
13-
#include <react/renderer/core/propsConversions.h>
12+
#include <React/RendererCore.h>
1413

1514
namespace facebook::react {
1615

‎packages/rn-tester/NativeCxxModuleExample/NativeCxxModuleExample.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
*/
77

88
#include "NativeCxxModuleExample.h"
9-
#include <react/bridging/ArrayBuffer.h>
10-
#include <react/debug/react_native_assert.h>
9+
#include <React/Bridging.h>
10+
#include <React/Debug.h>
1111
#include <iomanip>
1212
#include <numeric>
1313
#include <ostream>

0 commit comments

Comments
 (0)