Skip to content

Commit e12c57e

Browse files
christophpurrermeta-codesync[bot]
authored andcommitted
Tolerate sub-pixel noise in rotated visual tests (#59430)
Summary: Pull Request resolved: #59430 Rotated transform screenshots compare pixel-exact, so one anti-aliased edge pixel fails the check. Give the three rotated transform tests the default `threshold`, `includeAA: false`, and `maxDiffPixels` of 100. Genuine rendering changes still alter thousands of pixels. Changelog: [Internal] Differential Revision: D127274477 fbshipit-source-id: 5490038470f7c349cbac1f80cf29a7c7dc0c5900
1 parent f9340f0 commit e12c57e

1 file changed

Lines changed: 17 additions & 1 deletion

File tree

‎packages/rn-tester/visual-tests/config.json‎

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,21 @@
44
"includeAA": true,
55
"maxDiffPixels": 0
66
},
7-
"tests": {}
7+
"tests": {
8+
"transform/rotate/default": {
9+
"threshold": 0.1,
10+
"includeAA": false,
11+
"maxDiffPixels": 100
12+
},
13+
"transform/rotate-scale/default": {
14+
"threshold": 0.1,
15+
"includeAA": false,
16+
"maxDiffPixels": 100
17+
},
18+
"transform/string/default": {
19+
"threshold": 0.1,
20+
"includeAA": false,
21+
"maxDiffPixels": 100
22+
}
23+
}
824
}

0 commit comments

Comments
 (0)