Skip to content

Commit f76f251

Browse files
christophpurrermeta-codesync[bot]
authored andcommitted
Delete gutted RCTModuleData class and its dead imports (#59426)
Summary: Pull Request resolved: #59426 `RCTModuleData` is never instantiated and its implementation is a stub: initializers return `self`, and `gatherConstants`/`invalidate` are no-ops. Delete the header and implementation with the unused `RCTBridgeModuleProvider` typedef and `RCTModuleDataCallInvokerProvider` protocol, plus the buck header-map entry and all import sites. Changelog: [iOS][Removed] - Remove deprecated `RCTModuleData` class and its call-invoker provider protocol Reviewed By: cipolleschi Differential Revision: D127228438 fbshipit-source-id: adbc0bdccf9216d5b1defd93ea5f32890ef5bd49
1 parent f2f393f commit f76f251

13 files changed

Lines changed: 0 additions & 253 deletions

File tree

‎packages/react-native/React/Base/RCTBridge.mm‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
#import "RCTInspectorUtils.h"
2525
#import "RCTJSThread.h"
2626
#import "RCTLog.h"
27-
#import "RCTModuleData.h"
2827
#import "RCTPausedInDebuggerOverlayController.h"
2928
#import "RCTPerformanceLogger.h"
3029
#import "RCTReloadCommand.h"

‎packages/react-native/React/Base/RCTModuleData.h‎

Lines changed: 0 additions & 123 deletions
This file was deleted.

‎packages/react-native/React/Base/RCTModuleData.mm‎

Lines changed: 0 additions & 43 deletions
This file was deleted.

‎packages/react-native/React/CxxModule/RCTCxxUtils.h‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#import <Foundation/Foundation.h>
1212

1313
@class RCTBridge;
14-
@class RCTModuleData;
1514

1615
namespace facebook::react {
1716

‎packages/react-native/React/CxxModule/RCTCxxUtils.mm‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
#import "RCTCxxUtils.h"
99

10-
#import <React/RCTModuleData.h>
1110
#import <React/RCTUtils.h>
1211
#import <cxxreact/CxxNativeModule.h>
1312
#import <jsi/jsi.h>

‎packages/react-native/React/Modules/RCTUIManager.mm‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#import "RCTLayoutAnimation.h"
2323
#import "RCTLayoutAnimationGroup.h"
2424
#import "RCTLog.h"
25-
#import "RCTModuleData.h"
2625
#import "RCTModuleMethod.h"
2726
#import "RCTScrollableProtocol.h"
2827
#import "RCTShadowView.h"

‎packages/react-native/ReactCommon/react/renderer/components/legacyviewmanagerinterop/platform/ios/react/renderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropComponentDescriptor.mm‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
#include <React/RCTBridgeProxy.h>
1616
#include <React/RCTComponentData.h>
1717
#include <React/RCTEventDispatcher.h>
18-
#include <React/RCTModuleData.h>
1918
#import <react/featureflags/ReactNativeFeatureFlags.h>
2019
#include <react/renderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropState.h>
2120
#include <react/utils/ContextContainer.h>

‎packages/react-native/ReactCommon/react/renderer/components/legacyviewmanagerinterop/platform/ios/react/renderer/components/legacyviewmanagerinterop/RCTLegacyViewManagerInteropCoordinator.mm‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include <React/RCTBridgeProxy.h>
1515
#include <React/RCTComponentData.h>
1616
#include <React/RCTEventDispatcherProtocol.h>
17-
#include <React/RCTModuleData.h>
1817
#include <React/RCTModuleMethod.h>
1918
#include <React/RCTUIManager.h>
2019
#include <React/RCTUIManagerUtils.h>

‎packages/react-native/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
#import <React/RCTEventDispatcherProtocol.h>
3030
#import <React/RCTLog.h>
3131
#import <React/RCTLogBox.h>
32-
#import <React/RCTModuleData.h>
3332
#import <React/RCTPerformanceLogger.h>
3433
#import <React/RCTRedBox.h>
3534
#import <React/RCTSurfacePresenter.h>

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1349,22 +1349,6 @@ interface RCTModalHostViewComponentView : public RCTViewComponentView <UIAdaptiv
13491349
public virtual void presentViewController:animated:completion:(UIViewController* modalViewController, BOOL animated, void(^)(void) completion);
13501350
}
13511351

1352-
interface RCTModuleData : public NSObject <RCTInvalidating> {
1353-
public @property (assign) BOOL requiresMainQueueSetup;
1354-
public @property (assign, readonly) BOOL hasConstantsToExport;
1355-
public @property (assign, readonly) BOOL hasInstance;
1356-
public @property (assign, readonly) BOOL implementsBatchDidComplete;
1357-
public @property (copy, readonly) NSArray<id<RCTBridgeMethod>>* methods;
1358-
public @property (copy, readonly) NSDictionary<NSString*, id<RCTBridgeMethod>>* methodsByName;
1359-
public @property (copy, readonly) NSDictionary<NSString*, id>* exportedConstants;
1360-
public @property (copy, readonly) NSString* name;
1361-
public @property (strong) id<RCTBridgeModule> instance;
1362-
public @property (strong, readonly) Class moduleClass;
1363-
public @property (strong, readonly) dispatch_queue_t methodQueue;
1364-
public @property (weak) id<RCTModuleDataCallInvokerProvider> callInvokerProvider;
1365-
public virtual void gatherConstants();
1366-
}
1367-
13681352
interface RCTModuleMethod : public NSObject <RCTBridgeMethod> {
13691353
public @property (assign, readonly) Class moduleClass;
13701354
public @property (assign, readonly) SEL selector;
@@ -2793,10 +2777,6 @@ protocol RCTLocalizationProtocol : public NSObject {
27932777
protocol RCTModalHostViewViewProtocol : public NSObject {
27942778
}
27952779

2796-
protocol RCTModuleDataCallInvokerProvider : public NSObject {
2797-
public virtual RCTCallInvoker* callInvokerForModuleData:(RCTModuleData* moduleData);
2798-
}
2799-
28002780
protocol RCTModuleProvider : public NSObjectNSObject {
28012781
public virtual std::shared_ptr<facebook::react::TurboModule> getTurboModule:(const facebook::react::ObjCTurboModule::InitParams& params);
28022782
}

0 commit comments

Comments
 (0)