Repository navigation
Include renderer core via its umbrella header in DOM.h - #59107
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
Summary: `DOM.h` is a "for frameworks" header but included `<react/renderer/core/ShadowNode.h>` directly. That header is in the public tier, so its `UmbrellaGuard` hard-errors when consumers opt into the strict API, and `RN_ALLOW_FRAMEWORKS` does not suppress it. Include the module umbrella `<React/RendererCore.h>` instead, which re-exports `ShadowNode.h`. `RootShadowNode.h` stays as a direct include: it is itself a "for frameworks" header and its module has no public umbrella. Changelog: [Internal] Differential Revision: D125435350
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125435350. |
|
This pull request has been merged in cca7207. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
DOM.his a "for frameworks" header but included<react/renderer/core/ShadowNode.h>directly. That header is in the public tier, so itsUmbrellaGuardhard-errors when consumers opt into the strict API, andRN_ALLOW_FRAMEWORKSdoes not suppress it. Include the module umbrella<React/RendererCore.h>instead, which re-exportsShadowNode.h.RootShadowNode.hstays as a direct include: it is itself a "for frameworks" header and its module has no public umbrella.Changelog: [Internal]
Differential Revision: D125435350