Repository navigation
Conversation
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125204355. |
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 16, 2026
…rarchy (react#59150) Summary: ## Summary `PreparedLayoutTextView` currently derives its exposed text from `Layout.getText()`. When Android ellipsizes a `StaticLayout`, that value is backed by `TextUtils.Ellipsizer`, whose string representation contains the rendered ellipsis instead of the complete source text. Accessibility services and view-hierarchy consumers can therefore receive truncated content. Preserve the original `CharSequence` in `PreparedLayout` and expose it from `PreparedLayoutTextView.getText()`. Drawing, hit testing, span handling, and selection continue to use the rendered layout text, so visual ellipsizing behaviour is unchanged. Changelog: [Android][Fixed] - Preserve complete text for accessibility when prepared text layouts are ellipsized Reviewed By: derekmeta Differential Revision: D125204355
javache
force-pushed
the
export-D125204355
branch
from
October 16, 2026 21:07
e8ebd13 to
365e4f0
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 16, 2026
…rarchy (react#59150) Summary: ## Summary `PreparedLayoutTextView` currently derives its exposed text from `Layout.getText()`. When Android ellipsizes a `StaticLayout`, that value is backed by `TextUtils.Ellipsizer`, whose string representation contains the rendered ellipsis instead of the complete source text. Accessibility services and view-hierarchy consumers can therefore receive truncated content. Preserve the original `CharSequence` in `PreparedLayout` and expose it from `PreparedLayoutTextView.getText()`. Drawing, hit testing, span handling, and selection continue to use the rendered layout text, so visual ellipsizing behaviour is unchanged. Changelog: [Android][Fixed] - Preserve complete text for accessibility when prepared text layouts are ellipsized Reviewed By: derekmeta Differential Revision: D125204355
javache
force-pushed
the
export-D125204355
branch
from
October 16, 2026 21:08
365e4f0 to
e60dff7
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 16, 2026
…rarchy (react#59150) Summary: Pull Request resolved: react#59150 ## Summary `PreparedLayoutTextView` currently derives its exposed text from `Layout.getText()`. When Android ellipsizes a `StaticLayout`, that value is backed by `TextUtils.Ellipsizer`, whose string representation contains the rendered ellipsis instead of the complete source text. Accessibility services and view-hierarchy consumers can therefore receive truncated content. Preserve the original `CharSequence` in `PreparedLayout` and expose it from `PreparedLayoutTextView.getText()`. Drawing, hit testing, span handling, and selection continue to use the rendered layout text, so visual ellipsizing behaviour is unchanged. Changelog: [Android][Fixed] - Preserve complete text for accessibility when prepared text layouts are ellipsized Reviewed By: derekmeta Differential Revision: D125204355
javache
force-pushed
the
export-D125204355
branch
from
October 16, 2026 21:10
e60dff7 to
996a6ff
Compare
…rarchy (react#59150) Summary: Pull Request resolved: react#59150 ## Summary `PreparedLayoutTextView` currently derives its exposed text from `Layout.getText()`. When Android ellipsizes a `StaticLayout`, that value is backed by `TextUtils.Ellipsizer`, whose string representation contains the rendered ellipsis instead of the complete source text. Accessibility services and view-hierarchy consumers can therefore receive truncated content. Preserve the original `CharSequence` in `PreparedLayout` and expose it from `PreparedLayoutTextView.getText()`. Drawing, hit testing, span handling, and selection continue to use the rendered layout text, so visual ellipsizing behaviour is unchanged. Changelog: [Android][Fixed] - Preserve complete text for accessibility when prepared text layouts are ellipsized Reviewed By: derekmeta Differential Revision: D125204355
javache
force-pushed
the
export-D125204355
branch
from
October 16, 2026 21:14
996a6ff to
d0f03fe
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
PreparedLayoutTextViewcurrently derives its exposed text fromLayout.getText(). When Android ellipsizes aStaticLayout, that value is backed byTextUtils.Ellipsizer, whose string representation contains the rendered ellipsis instead of the complete source text. Accessibility services and view-hierarchy consumers can therefore receive truncated content.Preserve the original
CharSequenceinPreparedLayoutand expose it fromPreparedLayoutTextView.getText(). Drawing, hit testing, span handling, and selection continue to use the rendered layout text, so visual ellipsizing behaviour is unchanged.Changelog:
[Android][Fixed] - Preserve complete text for accessibility when prepared text layouts are ellipsized
Reviewed By: derekmeta
Differential Revision: D125204355