Repository navigation
Warn only when Fantom root creation changes global dimensions - #59512
Closed
rubennorte wants to merge 1 commit into
Closed
rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
Summary: Avoid repeated warnings when a new root matches the current global dimensions, even if older roots have different metrics. Continue warning when another root is alive and the new root changes the current metrics. Changelog: [Internal] Compare Fantom root dimensions against current global metrics. Differential Revision: D127606984
meta-cla
Bot
added
the
CLA Signed
|
This pull request has been merged in b4a6544. |
Collaborator
|
This pull request was successfully merged by @rubennorte in b4a6544 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Avoid repeated warnings when a new root matches the current global dimensions, even if older roots have different metrics. Continue warning when another root is alive and the new root changes the current metrics.
Changelog: [Internal] Compare Fantom root dimensions against current global metrics.
Differential Revision: D127606984